timer: make sure timer which has a max delay will be scheduled first (#57067) #57158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #57067
What problem does this PR solve?
Issue Number: close #57137
This issue is because a trigger action will be sent to the timer worker via the chan:
tidb/pkg/timer/runtime/runtime.go
Lines 285 to 300 in 6004c3e
If the chan is full, it will fail and retry after a while. However, some tables always have lower priorities even if they are not triggered for a long time.
What changed and how does it work?
reorder timers by
nextEventTime
before sending them to workers to make sure the timer which has a max delay will be handled first to avoid starvationCheck List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.