-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log backup: set a proper maxVersion to resolve lock #57178
base: master
Are you sure you want to change the base?
Conversation
Hi @3pointer. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #57178 +/- ##
================================================
+ Coverage 73.0633% 74.0695% +1.0061%
================================================
Files 1659 1672 +13
Lines 458027 458014 -13
================================================
+ Hits 334650 339249 +4599
+ Misses 102843 97568 -5275
- Partials 20534 21197 +663
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Co-authored-by: 山岚 <[email protected]>
@3pointer: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #57134
Problem Summary:
What changed and how does it work?
To minimize the risk of lock conflicts, set the maxVersion to be the largest existing version value across all slow regions, incremented by 1. This adjustment helps optimize RPO by proactively reducing lock contention.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.