planner: remove skip prealloc tag #58805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Weizhen Wang <[email protected]>
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
do-not-merge/needs-tests-checked
release-note-none
Signed-off-by: Weizhen Wang <[email protected]>
ti-chi-bot
bot
added
size/S
Signed-off-by: Weizhen Wang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #58805 +/- ##
================================================
+ Coverage 73.0978% 74.2119% +1.1141%
================================================
Files 1676 1678 +2
Lines 463754 470283 +6529
================================================
+ Hits 338994 349006 +10012
+ Misses 103922 100609 -3313
+ Partials 20838 20668 -170
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ti-chi-bot
bot
removed
do-not-merge/needs-linked-issue
do-not-merge/needs-tests-checked
labels
AilinKid
approved these changes
Jan 14, 2025
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
lance6716
approved these changes
Jan 14, 2025
| @@ -216,18 +216,15 @@ func (s *joinReorderDPSolver) dpGraph(visitID2NodeID, nodeID2VisitID []int, _ [] | |||
|
|
|||
| func (*joinReorderDPSolver) nodesAreConnected(leftMask, rightMask uint, oldPos2NewPos []int, | |||
| totalEqEdges []joinGroupEqEdge, totalNonEqEdges []joinGroupNonEqEdge) ([]joinGroupEqEdge, []expression.Expression) { | |||
| //nolint: prealloc | |||
| var usedEqEdges []joinGroupEqEdge | |||
There was a problem hiding this comment.
lint may fail on this line
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #40786
Problem Summary:
What changed and how does it work?
remove the
//nolint: preallocCheck List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.