-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: remove the variable txn_scope #58839
base: master
Are you sure you want to change the base?
Conversation
Hi @ekexium. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #58839 +/- ##
================================================
+ Coverage 73.1419% 75.1141% +1.9722%
================================================
Files 1677 1723 +46
Lines 463823 474282 +10459
================================================
+ Hits 339249 356253 +17004
+ Misses 103716 95804 -7912
- Partials 20858 22225 +1367
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ab66aec
to
5bb3b68
Compare
Signed-off-by: ekexium <[email protected]>
5bb3b68
to
3e8e5c0
Compare
[LGTM Timeline notifier]Timeline:
|
/retest |
@ekexium: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cfzjywxk, crazycs520, joey-yez, tangenta The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@joey-yez: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What problem does this PR solve?
Issue Number: ref #58838
Problem Summary:
What changed and how does it work?
Remove the variable
txn_scope
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.