-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: avoid slicesgrow in the buildDataSource #58853
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Weizhen Wang <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #58853 +/- ##
================================================
+ Coverage 73.1123% 73.5271% +0.4147%
================================================
Files 1677 1677
Lines 463901 463962 +61
================================================
+ Hits 339169 341138 +1969
+ Misses 103885 101972 -1913
- Partials 20847 20852 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #58842
Problem Summary:
What changed and how does it work?
tidb/pkg/planner/core/logical_plan_builder.go
Lines 4648 to 4658 in cd9d3c0
here is the root causion of the slices grow. so we should add 1 to the capacity of column
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.