-
Notifications
You must be signed in to change notification settings - Fork 6.1k
*: Collect client network info for topsql to pick topN sql with highest network traffic #63796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Collect client network info for topsql to pick topN sql with highest network traffic #63796
Conversation
|
Hi @yibin87. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #63796 +/- ##
================================================
+ Coverage 72.7426% 73.4881% +0.7455%
================================================
Files 1859 1860 +1
Lines 504040 504265 +225
================================================
+ Hits 366652 370575 +3923
+ Misses 115130 111634 -3496
+ Partials 22258 22056 -202
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
64f35fc to
36587b4
Compare
36587b4 to
28f7f2d
Compare
|
/test check-dev2 |
|
@yibin87: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: yibin87 <[email protected]>
Signed-off-by: yibin87 <[email protected]>
Signed-off-by: yibin <[email protected]>
Signed-off-by: yibin87 <[email protected]>
Signed-off-by: yibin87 <[email protected]>
Signed-off-by: yibin87 <[email protected]>
Signed-off-by: yibin87 <[email protected]>
Signed-off-by: yibin87 <[email protected]>
Signed-off-by: yibin87 <[email protected]>
Signed-off-by: yibin87 <[email protected]>
Signed-off-by: yibin87 <[email protected]>
Signed-off-by: yibin87 <[email protected]>
416da1a to
b3321af
Compare
yudongusa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also open a document PR for this.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nolouch, yudongusa, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test mysql-test |
|
@yibin87: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test mysql-test |
|
@yibin87: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-8.5 |
Signed-off-by: ti-chi-bot <[email protected]>
|
@yibin87: new pull request created to branch DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/cherrypick release-8.5 |
|
@yibin87: new pull request could not be created: failed to create pull request against pingcap/tidb#release-8.5 from head ti-chi-bot:cherry-pick-63796-to-release-8.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-63796-to-release-8.5."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"} DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <[email protected]>
What problem does this PR solve?
Issue Number: close #62920
Problem Summary:
Add client network in/out stats in topsql. And record topN network usage sqls adding to current topN cpu usage sqls. Note one sql will be added at most once.
What changed and how does it work?
Check List
Sysbench Performance Test
The performance impact of this PR is not noticable.

Turn off topsql
Turn on topsql

Tests
Run tpch benchmark, print topsql report data on tidb side, and check the network in/out data using sql digest manually to ensure network data make sense.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.