br: batch restore compacted sst #64068

Leavrth · 2025-10-21T08:25:36Z

What problem does this PR solve?

Issue Number: close #64308

Problem Summary:
Ingest the overlapped SST files will cause a long tail in raftstore.

What changed and how does it work?

batch download the overlapped SST files and merge them into one SST file to be ingested.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Jianjun Liao <[email protected]>

tiprow · 2025-10-21T08:25:54Z

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2025-10-21T08:51:29Z

Codecov Report

❌ Patch coverage is 37.08791% with 229 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.6842%. Comparing base (749c973) to head (2101f05).
⚠️ Report is 15 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #64068        +/-   ##
================================================
+ Coverage   72.7381%   74.6842%   +1.9460%     
================================================
  Files          1859       1862         +3     
  Lines        503905     508307      +4402     
================================================
+ Hits         366531     379625     +13094     
+ Misses       115136     105709      -9427     
- Partials      22238      22973       +735

Flag	Coverage Δ
integration	`45.6238% <10.9890%> (?)`
unit	`72.6221% <29.3956%> (+0.3146%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.8700% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`62.3471% <37.0879%> (+15.9617%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Jianjun Liao <[email protected]>

Leavrth · 2025-11-05T05:26:14Z

/retest

tiprow · 2025-11-05T05:26:37Z

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Jianjun Liao <[email protected]>

3pointer · 2025-11-06T06:36:49Z

br/pkg/restore/snap_client/import.go

+		if s.State != metapb.StoreState_Up {
+			continue
+		}
+		storeIDs = append(storeIDs, s.Id)


assert(len(storeIDs) > 0)

3pointer · 2025-11-06T06:43:11Z

br/pkg/restore/snap_client/import.go

-
-		logutil.CL(ctx).Debug("scan regions", logutil.Key("start key", startKey), logutil.Key("end key", endKey), zap.Int("count", len(regionInfos)))
+		workerpoolsize := 1
+		if importer.mergeSst {


this looks like a general optimization, not only for compacted sst files?

Yes, but the number of regionInfos is usually 1 in the snapshot restore, which is not necessary.

3pointer · 2025-11-06T06:45:32Z

br/pkg/restore/snap_client/import.go

+					}
+
+					mu.Lock()
+					sstMeta := req.Sst


Need handle req.Ssts too?

For TiKV server, the input is req.Ssts and the output target is req.Sst. Therefore, just get the req.Sst to obtain the output of merged SST file.

Signed-off-by: Jianjun Liao <[email protected]>

BornChanger · 2025-11-06T07:40:21Z

/retest

tiprow · 2025-11-06T07:40:45Z

@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot · 2025-11-06T08:53:27Z

[LGTM Timeline notifier]

Timeline:

2025-11-06 07:49:26.078277758 +0000 UTC m=+342815.521307627: ☑️ agreed by 3pointer.
2025-11-06 08:53:25.86086681 +0000 UTC m=+346655.303896699: ☑️ agreed by YuJuncen.

Signed-off-by: Jianjun Liao <[email protected]>

BornChanger · 2025-11-06T09:02:12Z

/retest

tiprow · 2025-11-06T09:02:36Z

@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

BornChanger · 2025-11-06T10:02:02Z

/retest

tiprow · 2025-11-06T10:02:26Z

@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

purelind · 2025-11-06T10:18:51Z

/test pull-error-log-review

tiprow · 2025-11-06T10:19:14Z

@purelind: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-error-log-review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Leavrth · 2025-11-06T11:03:15Z

/ok-to-test

tiprow · 2025-11-06T11:17:25Z

@purelind: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test pull-error-log-review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2025-11-06T11:31:31Z

@purelind: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test pull-error-log-review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

purelind · 2025-11-06T11:35:22Z

/retest

bb7133

LGTM

ti-chi-bot · 2025-11-06T11:59:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, bb7133, BornChanger, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [3pointer,BornChanger,YuJuncen,bb7133]
~~br/OWNERS~~ [3pointer,BornChanger,YuJuncen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Leavrth added 2 commits October 21, 2025 15:17

batch restore compated sst

6bc03f3

Signed-off-by: Jianjun Liao <[email protected]>

fix typos

72299c8

Signed-off-by: Jianjun Liao <[email protected]>

ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Oct 21, 2025

Leavrth added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 21, 2025

BornChanger changed the title ~~br: batch restore compated sst~~ br: batch restore compacted sst Oct 21, 2025

ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 21, 2025

support to batch download

908a2aa

Signed-off-by: Jianjun Liao <[email protected]>

ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 28, 2025

Leavrth added 5 commits October 29, 2025 16:34

fix bug

eba5e01

Signed-off-by: Jianjun Liao <[email protected]>

concurrently restore if merge sst

e1a7b0b

Signed-off-by: Jianjun Liao <[email protected]>

debug to info

c1b75b1

Signed-off-by: Jianjun Liao <[email protected]>

update kvproto

01a585f

Signed-off-by: Jianjun Liao <[email protected]>

Merge branch 'master' into batch_restore_compacted_sst

5098b21

Leavrth added 3 commits November 6, 2025 11:13

fix bug

52cf7f0

Signed-off-by: Jianjun Liao <[email protected]>

bazel prepare

5342456

Signed-off-by: Jianjun Liao <[email protected]>

fix typos

7f17bd1

Signed-off-by: Jianjun Liao <[email protected]>

ti-chi-bot bot removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Nov 6, 2025

3pointer reviewed Nov 6, 2025

View reviewed changes

fix typos

a2a92cc

Signed-off-by: Jianjun Liao <[email protected]>

3pointer approved these changes Nov 6, 2025

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 6, 2025

YuJuncen approved these changes Nov 6, 2025

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 6, 2025

commit some suggestions

2101f05

Signed-off-by: Jianjun Liao <[email protected]>

BornChanger approved these changes Nov 6, 2025

View reviewed changes

ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Nov 6, 2025

bb7133 approved these changes Nov 6, 2025

View reviewed changes

ti-chi-bot bot added the approved label Nov 6, 2025

ti-chi-bot bot merged commit 552b369 into pingcap:master Nov 6, 2025
30 of 34 checks passed

br: batch restore compacted sst #64068

br: batch restore compacted sst #64068

Uh oh!

Conversation

Leavrth commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Uh oh!

tiprow bot commented Oct 21, 2025

Uh oh!

codecov bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Leavrth commented Nov 5, 2025

Uh oh!

tiprow bot commented Nov 5, 2025

Uh oh!

3pointer Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

3pointer Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Leavrth Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

3pointer Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Leavrth Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

BornChanger commented Nov 6, 2025

Uh oh!

tiprow bot commented Nov 6, 2025

Uh oh!

ti-chi-bot bot commented Nov 6, 2025

[LGTM Timeline notifier]

Uh oh!

BornChanger commented Nov 6, 2025

Uh oh!

tiprow bot commented Nov 6, 2025

Uh oh!

BornChanger commented Nov 6, 2025

Uh oh!

tiprow bot commented Nov 6, 2025

Uh oh!

purelind commented Nov 6, 2025

Uh oh!

tiprow bot commented Nov 6, 2025

Uh oh!

Leavrth commented Nov 6, 2025

Uh oh!

tiprow bot commented Nov 6, 2025

Uh oh!

tiprow bot commented Nov 6, 2025

Uh oh!

purelind commented Nov 6, 2025

Uh oh!

bb7133 left a comment

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot bot commented Nov 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Leavrth commented Oct 21, 2025 •

edited

Loading

codecov bot commented Oct 21, 2025 •

edited

Loading