-
Notifications
You must be signed in to change notification settings - Fork 6k
planner: add the variable PlanCacheMaxDecimalParamNums to restrict the number of decimal values in plan cache
#64306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…the decimal values in plan cache
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @Reminiscent. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #64306 +/- ##
================================================
+ Coverage 72.7515% 73.0030% +0.2515%
================================================
Files 1859 1861 +2
Lines 504182 506261 +2079
================================================
+ Hits 366800 369586 +2786
+ Misses 115122 114459 -663
+ Partials 22260 22216 -44
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
pkg/sessionctx/vardef/tidb_vars.go
Outdated
| DefTiDBSchemaCacheSize = 512 * 1024 * 1024 | ||
| DefTiDBLowResolutionTSOUpdateInterval = 2000 | ||
| DefDivPrecisionIncrement = 4 | ||
| DefTiDBPlanCacheMaxDecimalParamNums = 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should disable this by default to keep the same behavior.
|
@Reminiscent: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@Reminiscent: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: ref #58576
Problem Summary:
Add an variable to control how many decimal values allowed in the plan cache.
What changed and how does it work?
We'll check the parameter's type. If the number of decimal values more than the settings. We'll skip the plan cache for this case
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.