-
Notifications
You must be signed in to change notification settings - Fork 6k
ddl: Cast flen for longblob/longjson types in tableInfo for TiCI. | tidb-test=ef726505f262e22c6ec9c8951273bb5ee20abefb #64310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/fts
Are you sure you want to change the base?
Conversation
|
Hi @OliverS929. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature/fts #64310 +/- ##
===================================================
- Coverage 74.4116% 70.9475% -3.4641%
===================================================
Files 1889 1842 -47
Lines 508453 513898 +5445
===================================================
- Hits 378348 364598 -13750
- Misses 106590 127281 +20691
+ Partials 23515 22019 -1496
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
203aa20 to
2f2f0c0
Compare
|
@kolafish: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kolafish The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
| // length as int32 and avoids 4GB default-value related errors. | ||
| func cloneAndNormalizeTableInfo(tbl *model.TableInfo) (*model.TableInfo, error) { | ||
| // nil guard | ||
| if tbl == nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should here return an error?
What problem does this PR solve?
Issue Number: ref #64255
Problem Summary:
TiDB uses int for FieldType.flen, and TiCI sides expects int32 for the same field. By this PR tici_manager will cast FieldType.flen into an int32 value out of the deep copy of the original tableInfo, before serialize the copied tableInfo to TiCI.
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.