planner: tolerate reasonable time lag between different TiDB nodes when updating binding cache (#64289)

[ti-chi-bot]

This is an automated cherry-pick of #64289

What problem does this PR solve?

Issue Number: close #64250

Problem Summary: planner: tolerate reasonable time lag between different TiDB nodes when updating binding cache

What changed and how does it work?

When updating binding cache, TiDB doesn't consider time lag between different nodes, which could cause inconsistency on binding cache. See more info in #64250.

Below is an simplified example, TiDB1's clock is consistent with the real time, while TiDB2's clock is 0.5s slower than the real time:

Real Physical Time	Action of TiDB1	Action of TiDB2
t1 00:00:30.200000	create the new binding, write it into mysql.bind_info with timestamp 00:00:30.200000	-
t2 00:00:30.300000	update binding cache: 1) load latest binding from mysql.bind_info where binding.update_time > LAST_UPDATE_TIME, 2) set LAST_UPDATE_TIME to the latest binding.update_time, in this case its 00:00:30.200000	-
t3 00:00:30.500000	-	create a new binding with timestamp 00:00:30.000000 due to system lock issue
t4 00:00:30.600000	-	update its binding cache
t5 00:01:00.000000	update binding cache, can't see the binding crated by TiDB2 ❌	-

In the case above, TiDB1 can never see the binding created by TiDB2 with timestamp 00:00:30.000000 because its LAST_UPDATE_TIME = 00:00:30.200000 is larger than that binding's timestamp.

The solution is simple, set a tolerance interval (10s by default) when updating binding cache. And it's safe to load duplicated bindings, because we'll deduplicate them before actually putting them into the cache.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign elsa0520 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/bindinfo/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

1. It must be approved by the approvers firstly.
2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot]

@qw4990 This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

[ti-chi-bot]

@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
idc-jenkins-ci-tidb/build	c7fa723	link	true	/test build
idc-jenkins-ci-tidb/check_dev_2	c7fa723	link	true	/test check-dev2
idc-jenkins-ci-tidb/unit-test	c7fa723	link	true	/test unit-test
idc-jenkins-ci-tidb/mysql-test	c7fa723	link	true	/test mysql-test
idc-jenkins-ci-tidb/check_dev	c7fa723	link	true	/test check-dev

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.