-
Notifications
You must be signed in to change notification settings - Fork 6k
ddl: partially revert removing auto id rebase from submitter #64356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Ruihao Chen <[email protected]>
|
Hi @joechenrh. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/hold BR is now testing... |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #64356 +/- ##
================================================
+ Coverage 72.7175% 73.6092% +0.8916%
================================================
Files 1861 1883 +22
Lines 504823 512820 +7997
================================================
+ Hits 367095 377483 +10388
+ Misses 115430 111628 -3802
- Partials 22298 23709 +1411
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Signed-off-by: Ruihao Chen <[email protected]>
Signed-off-by: Ruihao Chen <[email protected]>
Signed-off-by: Ruihao Chen <[email protected]>
Signed-off-by: Ruihao Chen <[email protected]>
Signed-off-by: Ruihao Chen <[email protected]>
Signed-off-by: Ruihao Chen <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, GMHDBJD The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Ruihao Chen <[email protected]>
What problem does this PR solve?
Issue Number: ref #60804
Problem Summary:
What changed and how does it work?
In #60804, we move auto id rebase from submitter to executor, to ensure the atomicity of create table.
In most cases, there are no problem with such changes. But BR sometimes backup db to lower version of TiDB cluster. For example, if BR with ver9.0 (or any version with #60804) backups db to TiDB with ver7.5 (or any version without #60804), rebase won't be executed by anyone.
To temporary solve this, this PR revert back part of the changes in #60804 to make backup happy again 😢.
Check List
Tests
Manual tests TBD.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.