-
Notifications
You must be signed in to change notification settings - Fork 6k
sessionctx,traceevent: support flight recorder sink to log and update @@tidb_trace_event #64362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…uce @@tidb_trace_event_control
|
[FORMAT CHECKER NOTIFICATION] Notice: To remove the For example:
📖 For more info, you can check the "Contribute Code" section in the development guide. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @tiancaiamao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #64362 +/- ##
================================================
+ Coverage 72.7353% 73.1941% +0.4588%
================================================
Files 1862 1862
Lines 505221 505338 +117
================================================
+ Hits 367474 369878 +2404
+ Misses 115427 113234 -2193
+ Partials 22320 22226 -94
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
@tiancaiamao: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: ref #64008
Problem Summary:
What changed and how does it work?
Support flight recorder sink trace events to log.
A new SQL variable@@tidb_trace_event_controlis introduced.Update
@@tidb_trace_eventto support json configHere is how to use it:
All events:
1/1000 Sampling:
Filter by categories:
Filter by user command, like sql regexp, plan digest, login user etc, here is example of plan_digest:
Filter by suspicious_event, like query fail, resolve lock, slow query etc:
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.