-
Notifications
You must be signed in to change notification settings - Fork 6.1k
ddl, metrics: move temp index op metrics to separate panel #65501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
ddl, metrics: move temp index op metrics to separate panel #65501
Conversation
Signed-off-by: Ruihao Chen <[email protected]>
Signed-off-by: Ruihao Chen <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @joechenrh. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Ruihao Chen <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #65501 +/- ##
================================================
+ Coverage 78.3437% 78.6576% +0.3138%
================================================
Files 1941 1910 -31
Lines 535546 532902 -2644
================================================
- Hits 419567 419168 -399
+ Misses 114459 112306 -2153
+ Partials 1520 1428 -92
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
/retest |
|
@joechenrh: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Ruihao Chen <[email protected]>
Signed-off-by: Ruihao Chen <[email protected]>
Signed-off-by: Ruihao Chen <[email protected]>
|
@joechenrh: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: ref #63209
Problem Summary:
What changed and how does it work?
Since the "Backfill Progress" panel is used to show the progress (in percentage) of reorg jobs. It's a bit strange to add temp index ops in this panel. So I separate those metrics into a new panel.
Besides, I asked AI to refactor the collector to make the code clearer.
Check List
Tests
Import the json file in this PR and run add index.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.