test: stabilize TestKillAutoAnalyzeIndex by cleanup corrupted job explicitly

[tangenta]

What problem does this PR solve?

Issue Number: close #62993

Problem Summary:

Fixed the flake by ensuring aborted/killed ANALYZE always finalizes its rows in mysql.analyze_jobs (previously it could exit early and leave jobs stuck in running, which breaks TestKillAutoAnalyzeIndex).

What changed and how does it work?

Fixed TestKillAutoAnalyzeIndex flakiness by finalizing killed jobs via CleanupCorruptedAnalyzeJobsOnCurrentInstance (forcing mysql.analyze_jobs.update_time old enough to be eligible), and asserting the job ends up failed without relying on immediate in-executor finalization.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign c4pt0r for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.6504%. Comparing base (69a1b2c) to head (90567e9).

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #65519        +/-   ##
================================================
- Coverage   77.8448%   77.6504%   -0.1945%     
================================================
  Files          1971       1895        -76     
  Lines        540836     528530     -12306     
================================================
- Hits         421013     410406     -10607     
+ Misses       118164     118118        -46     
+ Partials       1659          6      -1653     

Flag	Coverage Δ
integration	41.5265% <ø> (-6.6730%)	⬇️
unit	76.7656% <ø> (+0.3196%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	56.7974% <ø> (ø)
parser	∅ <ø> (∅)
br	48.8157% <ø> (-12.3062%)	⬇️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[0xPoe]

Maybe we should consider fixing the test itself. This case should be covered by: CleanupCorruptedAnalyzeJobsOnCurrentInstance.