Skip to content

Conversation

@YuJuncen
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #(TBD)

Problem Summary:

From __agent_doc/main.md

You need to implement a feature -- segmented restore.

Now, br restore point requires the user to finish restore to a point-in-time within oneshot.

We want br restore point can be "segmented", like:

br restore point --pd 127.0.0.1:2379 -s local:///Volumes/eXternal/Cache/tmp/20260122_003925/incr --restored-ts 463736294698909699 --full-backup-storage local:///Volumes/eXternal/Cache/tmp/20260122_003925/full --last=false
/br restore point --pd 127.0.0.1:2379 -s local:///Volumes/eXternal/Cache/tmp/20260122_003925/incr --restored-ts 463736295708426243 --start-ts 463736294698909699 --last=false
/br restore point --pd 127.0.0.1:2379 -s local:///Volumes/eXternal/Cache/tmp/20260122_003925/incr --restored-ts ... --start-ts 463736295708426243 --last=true

But for now, it is impossible. There are something we have known: tiflash replicas may be added back too early, indices may not be properly recreated... But more are unknown unknown.


What changed and how does it work?

  • Persisted {TiFlash|Ingest} recorder status during segemented restore.
  • Use dedicated function to load id maps from previous restore.
  • Added a real-tikv-test case to verify the function.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 28, 2026
@tiprow
Copy link

tiprow bot commented Jan 28, 2026

Hi @YuJuncen. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Juncen Yu <[email protected]>
Signed-off-by: Juncen Yu <[email protected]>
Signed-off-by: Juncen Yu <[email protected]>
Signed-off-by: Juncen Yu <[email protected]>
Signed-off-by: Juncen Yu <[email protected]>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 3, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133, leavrth for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Juncen Yu <[email protected]>
Signed-off-by: Juncen Yu <[email protected]>
Signed-off-by: Juncen Yu <[email protected]>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 3, 2026

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

📖 For more info, you can check the "Contribute Code" section in the development guide.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 3, 2026

@YuJuncen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev_2 dea4ab0 link true /test check-dev2
pull-integration-realcluster-test-next-gen dea4ab0 link true /test pull-integration-realcluster-test-next-gen
idc-jenkins-ci-tidb/check_dev dea4ab0 link true /test check-dev
pull-br-integration-test dea4ab0 link true /test pull-br-integration-test
pull-build-next-gen dea4ab0 link true /test pull-build-next-gen
pull-mysql-client-test dea4ab0 link true /test pull-mysql-client-test
idc-jenkins-ci-tidb/build dea4ab0 link true /test build
pull-mysql-client-test-next-gen dea4ab0 link true /test pull-mysql-client-test-next-gen
idc-jenkins-ci-tidb/mysql-test dea4ab0 link true /test mysql-test
pull-integration-e2e-test dea4ab0 link true /test pull-integration-e2e-test
pull-unit-test-next-gen dea4ab0 link true /test pull-unit-test-next-gen
idc-jenkins-ci-tidb/unit-test dea4ab0 link true /test unit-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant