-
Notifications
You must be signed in to change notification settings - Fork 6.1k
pkg/ddl, pkg/sessionctx: pass fulltext sysvars to TiCI #65967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/fts
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature/fts #65967 +/- ##
===================================================
+ Coverage 72.3094% 72.3861% +0.0767%
===================================================
Files 1895 1919 +24
Lines 533272 534938 +1666
===================================================
+ Hits 385606 387221 +1615
+ Misses 123717 123515 -202
- Partials 23949 24202 +253
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest |
|
@wjhuang2016: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: ref #xxx
Problem Summary:
What changed and how does it work?
pkg/tici/tici.proto) to carryCreateIndexRequest.parser_infoandParserInfo.stop_words.parser_info.parser_paramsfrom job sysvars and (for standard parser + stopwords enabled + stopword table configured) reads stopwords from the table (single VARCHAR columnvalue) and sends the de-duplicated list viaparser_info.stop_words.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.