Skip to content

Conversation

@AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Feb 3, 2026

What problem does this PR solve?

Issue Number: ref #65781

Problem Summary:

  • Index join inner build has duplicated partition pruning + range building in IndexReader and IndexLookUpReader paths.

What changed and how does it work?

  • Extracted a shared helper to compute partitions/ranges for index join inner readers and reused it in both paths.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 3, 2026
@tiprow
Copy link

tiprow bot commented Feb 3, 2026

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

❌ Patch coverage is 67.85714% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.5865%. Comparing base (97c2efc) to head (e865b04).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #65993        +/-   ##
================================================
- Coverage   77.7249%   77.5865%   -0.1385%     
================================================
  Files          2001       1923        -78     
  Lines        545885     534559     -11326     
================================================
- Hits         424289     414746      -9543     
+ Misses       119934     119807       -127     
+ Partials       1662          6      -1656     
Flag Coverage Δ
integration 41.6415% <53.5714%> (-6.5452%) ⬇️
unit 76.7268% <67.8571%> (+0.3406%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 56.7974% <ø> (ø)
parser ∅ <ø> (∅)
br 48.8730% <ø> (-12.1106%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@guo-shaoge guo-shaoge self-requested a review February 3, 2026 11:49
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 3, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 3, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-02-03 13:38:04.882459278 +0000 UTC m=+187755.983857997: ☑️ agreed by hawkingrei.

@hawkingrei
Copy link
Member

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants