Skip to content

Conversation

@wshwsh12
Copy link
Contributor

@wshwsh12 wshwsh12 commented Feb 3, 2026

What problem does this PR solve?

Issue Number: close https://github.com/pingcap-inc/tici/issues/736

Problem Summary:
When all TiFlash nodes are unavailable, TiCI (fulltext) queries may silently return an empty result set instead of an error.

What changed and how does it work?

  • Treat fulltext batch cop tasks (TableShardInfos) as non-retriable in retryBatchCopTask.
  • When a TiFlash request fails and the sender requests a retry, return tiflash_fts node is unavailable instead of rebuilding an empty task set.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 3, 2026
@tiprow
Copy link

tiprow bot commented Feb 3, 2026

Hi @wshwsh12. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wshwsh12 wshwsh12 requested a review from Copilot February 3, 2026 15:00
@wshwsh12
Copy link
Contributor Author

wshwsh12 commented Feb 3, 2026

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Feb 3, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where TiCI (fulltext) queries could silently return an empty result set instead of returning an error when all TiFlash nodes are unavailable.

Changes:

  • Added early return with error in retryBatchCopTask when encountering fulltext batch cop tasks (identified by TableShardInfos)
  • Added unit test to verify the error is returned when retrying fulltext tasks

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
pkg/store/copr/batch_coprocessor.go Adds check to return error "tiflash_fts node is unavailable" when attempting to retry fulltext tasks that cannot be rebuilt with region info
pkg/store/copr/batch_coprocessor_test.go Adds unit test to verify retry behavior for fulltext tasks returns an error

@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.8297%. Comparing base (2d2bd57) to head (b654b13).
⚠️ Report is 48 commits behind head on feature/fts.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           feature/fts     #66005        +/-   ##
===================================================
- Coverage      72.3094%   70.8297%   -1.4797%     
===================================================
  Files             1895       1873        -22     
  Lines           533272     526461      -6811     
===================================================
- Hits            385606     372891     -12715     
- Misses          123717     131001      +7284     
+ Partials         23949      22569      -1380     
Flag Coverage Δ
integration 40.0040% <0.0000%> (-6.2752%) ⬇️
unit 69.9132% <100.0000%> (+0.0292%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 46.2610% <ø> (-16.7777%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wshwsh12 wshwsh12 changed the title store/copr: return error when TiFlash fulltext is unavailable store/copr: return error when TiFlash fulltext is unavailable | tidb-test=a9bf2dca824dc746361234cd4d763178e0eedd13 tiflash=feature-fts Feb 4, 2026
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 4, 2026
@ChangRui-Ryan
Copy link
Contributor

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gengliqi, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 4, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 4, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-02-04 03:13:40.408372926 +0000 UTC m=+236691.509771647: ☑️ agreed by windtalker.
  • 2026-02-04 03:43:35.307287054 +0000 UTC m=+238486.408685769: ☑️ agreed by gengliqi.

@wshwsh12
Copy link
Contributor Author

wshwsh12 commented Feb 4, 2026

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants