-
Notifications
You must be signed in to change notification settings - Fork 6.1k
store/copr: return error when TiFlash fulltext is unavailable | tidb-test=a9bf2dca824dc746361234cd4d763178e0eedd13 tiflash=feature-fts #66005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/fts
Are you sure you want to change the base?
Conversation
|
Hi @wshwsh12. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a bug where TiCI (fulltext) queries could silently return an empty result set instead of returning an error when all TiFlash nodes are unavailable.
Changes:
- Added early return with error in
retryBatchCopTaskwhen encountering fulltext batch cop tasks (identified byTableShardInfos) - Added unit test to verify the error is returned when retrying fulltext tasks
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/store/copr/batch_coprocessor.go | Adds check to return error "tiflash_fts node is unavailable" when attempting to retry fulltext tasks that cannot be rebuilt with region info |
| pkg/store/copr/batch_coprocessor_test.go | Adds unit test to verify retry behavior for fulltext tasks returns an error |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/fts #66005 +/- ##
===================================================
- Coverage 72.3094% 70.8297% -1.4797%
===================================================
Files 1895 1873 -22
Lines 533272 526461 -6811
===================================================
- Hits 385606 372891 -12715
- Misses 123717 131001 +7284
+ Partials 23949 22569 -1380
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
windtalker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gengliqi, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/retest |
What problem does this PR solve?
Issue Number: close https://github.com/pingcap-inc/tici/issues/736
Problem Summary:
When all TiFlash nodes are unavailable, TiCI (fulltext) queries may silently return an empty result set instead of an error.
What changed and how does it work?
TableShardInfos) as non-retriable inretryBatchCopTask.tiflash_fts node is unavailableinstead of rebuilding an empty task set.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.