Skip to content

planner: fix the incorrect int pk null range for tici #66006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
winoros wants to merge 1 commit into
base: feature/fts
Choose a base branch
from
+14 −1
Open

planner: fix the incorrect int pk null range for tici #66006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/planner/core/casetest/tici/testdata/tici_index_suite_in.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"cases": [
"explain format='brief' select * from t1 where fts_match_word('hello', title)",
"explain format='brief' select * from t1 where fts_match_phrase('hello', title)",
"explain format='brief' select title from t1 where fts_match_word('hello', title)",
"explain format='brief' select * from t1 where fts_match_prefix('hello', title)",
"explain format='brief' select * from t1 where fts_match_prefix('hello', title) and id = 10",
"explain format='brief' select id from t1 where fts_match_word('hello', title)",
Expand Down
8 changes: 8 additions & 0 deletions pkg/planner/core/casetest/tici/testdata/tici_index_suite_out.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,14 @@
],
"Warn": null
},
{
"SQL": "explain format='brief' select title from t1 where fts_match_word('hello', title)",
"Plan": [
"IndexReader 1000.00 root index:IndexRangeScan",
"└─IndexRangeScan 1000.00 cop[tici] table:t1, index:idx_title(title) range:[-inf,+inf], search func:fts_match_word(\"hello\", test.t1.title), keep order:false, stats:pseudo"
],
"Warn": null
},
{
"SQL": "explain format='brief' select * from t1 where fts_match_prefix('hello', title)",
"Plan": [
Expand Down
6 changes: 5 additions & 1 deletion pkg/planner/core/stats.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,17 +194,21 @@ func fillIndexPath(ds *logicalop.DataSource, path *util.AccessPath, conds []expr
if path.Index.IsTiCIIndex() {
if path.Index.HybridInfo != nil && path.Index.HybridInfo.Sharding != nil {
ticiType = distsql.TiCIShardExtraShardingKey
path.Ranges = ranger.FullRange()
} else if ds.TableInfo.IsCommonHandle {
ticiType = distsql.TiCIShardCommonHandle
path.Ranges = ranger.FullRange()
} else {
ticiType = distsql.TiCIShardIntHandle
// Int Handle's range is a special one.
path.Ranges = ranger.FullIntRange(mysql.HasUnsignedFlag(ds.TableInfo.GetPkColInfo().GetFlag()))
}
path.IdxCols, path.IdxColLens = expression.TiCIIndexInfo2ShardCols(ds.Columns, ds.Schema().Columns, path.Index, possiblePK)
} else {
path.IdxCols, path.IdxColLens = expression.IndexInfo2PrefixCols(ds.Columns, ds.Schema().Columns, path.Index)
path.Ranges = ranger.FullRange()
}
path.FullIdxCols, path.FullIdxColLens = expression.IndexInfo2Cols(ds.Columns, ds.Schema().Columns, path.Index)
path.Ranges = ranger.FullRange()
path.CountAfterAccess = float64(ds.StatisticTable.RealtimeCount)
path.MinCountAfterAccess = 0
path.MaxCountAfterAccess = 0
Expand Down