-
Notifications
You must be signed in to change notification settings - Fork 322
repo: abstract v1repoapi as interface #2542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: xhe <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: xhe <[email protected]>
Signed-off-by: xhe <[email protected]>
Signed-off-by: xhe <[email protected]>
Signed-off-by: xhe <[email protected]>
} | ||
|
||
// NewRepository returns repository | ||
func NewRepository(os, arch string) (Repository, error) { | ||
profile := localdata.InitProfile() | ||
mirror := repository.NewMirror(environment.Mirror(), repository.MirrorOptions{ | ||
Progress: repository.DisableProgress{}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is one different change, DisableProgress behavior is introduced by 5b045ab
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2542 +/- ##
==========================================
- Coverage 53.81% 53.81% -0.00%
==========================================
Files 351 351
Lines 37425 37390 -35
==========================================
- Hits 20137 20118 -19
+ Misses 14872 14854 -18
- Partials 2416 2418 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What problem does this PR solve?
Replace V1Repository into an interface, such that we can safely replace it with minimum effort.
Check List
Tests
Code changes
Side effects
Related changes
Release notes: