WIP: Add dependency check to Makefile #2544
Open
+31
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
the
do-not-merge/work-in-progress
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
the
size/M
Introduce a new `check-dependencies` target that verifies the presence of required system packages and Go tools on Debian systems. This improves the developer experience by providing clear, actionable feedback if necessary dependencies are missing. Instead of failing with cryptic errors during the build or test phases, the user is informed upfront and given instructions on how to install the missing components. Additionally, fix goimports execution in fmt target. The `$(shell ...)` make function is evaluated when the Makefile is first parsed, not when a target is executed. This caused `goimports` to run every time `make` was invoked, regardless of the specified target, including for unrelated targets like `make clean`.
ottok
force-pushed
the
feature-make-target-check-dependencies
branch
from
3af5f7c to
39303ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT - DO NOT MERGE
Introduce a new
check-dependenciestarget that verifies the presence of required system packages and Go tools on Debian systems. This improves the developer experience by providing clear, actionable feedback if necessary dependencies are missing. Instead of failing with cryptic errors during the build or test phases, the user is informed upfront and given instructions on how to install the missing components.Additionally, fix goimports execution in fmt target. The
$(shell ...)make function is evaluated when the Makefile is first parsed, not when a target is executed. This causedgoimportsto run every timemakewas invoked, regardless of the specified target, including for unrelated targets likemake clean.Check List
Tests
Side effects
Release notes: