Skip to content

Conversation

@rleungx
Copy link
Member

@rleungx rleungx commented Sep 5, 2025

What problem does this PR solve?

close #xxx

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xhebox for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 5, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.17%. Comparing base (e769cc5) to head (aae3a82).

⚠️ Current head aae3a82 differs from pull request most recent head e8793bf

Please upload reports for the commit e8793bf to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2600      +/-   ##
==========================================
+ Coverage   40.86%   42.17%   +1.31%     
==========================================
  Files         363      335      -28     
  Lines       37725    36208    -1517     
==========================================
- Hits        15415    15268     -147     
+ Misses      20397    19030    -1367     
+ Partials     1913     1910       -3     
Flag Coverage Δ
tiup 33.88% <ø> (ø)
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
@rleungx rleungx changed the title Support router and admission control services Support router and resource manager services Sep 23, 2025
Signed-off-by: Ryan Leung <[email protected]>
@rleungx rleungx marked this pull request as ready for review September 23, 2025 10:02
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2025
@ti-chi-bot ti-chi-bot bot requested a review from nexustar September 23, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants