cluster: support retention by size for prometheus #2612
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
contribution
size/L
| AdditionalArgs: spec.AdditionalArgs, | ||
| } | ||
| // Set retention policy | ||
| if spec.RetentionTime == "" { |
There was a problem hiding this comment.
This is to handle the deprecated Retention, right? Maybe add a comment about this. Could also be a good place to emit a warning about the use of deprecated things.
| func getRetention(retention string) string { | ||
| func getRetentionSize(retention string) string { | ||
| retention = strings.ToUpper(strings.TrimSpace(retention)) | ||
| valid, _ := regexp.MatchString("^[1-9]\\d*(B|KB|MB|GB|TB|PB|EB)$", retention) |
There was a problem hiding this comment.
Didn't see that in Prometheus doc though...
| retention = strings.ToUpper(strings.TrimSpace(retention)) | ||
| valid, _ := regexp.MatchString("^[1-9]\\d*(B|KB|MB|GB|TB|PB|EB)$", retention) | ||
| if retention == "" || !valid { | ||
| return "" |
There was a problem hiding this comment.
Can we log a warning or something similar if !valid ?
|
@dveeden: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
2 participants
What problem does this PR solve?
Add support of retention by size for Prometheus. Default value is empty to keep former behavior unchanged. The
storage.tsdb.retention.sizeandstorage.tsdb.retention.timecan be set together.See Prometheus doc for details.
Also close #2058
Check List
Tests
Code changes
Side effects
Related changes
Release notes: