Skip to content

Conversation

@dveeden
Copy link
Contributor

@dveeden dveeden commented Nov 7, 2025

What problem does this PR solve?

close #2611

What is changed and how it works?

  1. The path for the tiup_process_meta was not build correctly.
  2. This caused other tools like tiup status and tiup clean to consider the datadir to be abandoned and delete it.
  3. Deleting the datadir for a running playground caused components to stop/crash

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

playground: Fix the location to which the metadata file was written. 

@ti-chi-bot ti-chi-bot bot requested review from breezewish and nexustar November 7, 2025 08:39
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xhebox for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 7, 2025
@dveeden
Copy link
Contributor Author

dveeden commented Nov 7, 2025

/cc @xhebox

@ti-chi-bot ti-chi-bot bot requested a review from xhebox November 7, 2025 08:39
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 7, 2025
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 41.28%. Comparing base (e782bc1) to head (972ed89).

Files with missing lines Patch % Lines
pkg/localdata/profile.go 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2638      +/-   ##
==========================================
+ Coverage   41.24%   41.28%   +0.04%     
==========================================
  Files         363      363              
  Lines       37544    37545       +1     
==========================================
+ Hits        15485    15499      +14     
+ Misses      20135    20121      -14     
- Partials     1924     1925       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dveeden
Copy link
Contributor Author

dveeden commented Nov 7, 2025

/test all

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 7, 2025

@dveeden: No presubmit jobs available for pingcap/tiup@master

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dveeden
Copy link
Contributor Author

dveeden commented Nov 7, 2025

/retest all

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 7, 2025

@dveeden: No presubmit jobs available for pingcap/tiup@master

In response to this:

/retest all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dveeden dveeden force-pushed the playground__metafile branch from 856a46e to b30bd81 Compare November 7, 2025 09:58
@wuhuizuo
Copy link
Contributor

wuhuizuo commented Nov 7, 2025

/retest all

@dveeden use /retest without any args.

prow will help to rerun the failed GitHub action jobs.

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Nov 7, 2025

/retest

@dveeden
Copy link
Contributor Author

dveeden commented Nov 7, 2025

@wuhuizuo I wanted to re-run the successful actions to re-try the upload to codecov. But that's now being fixed in #2639

Note that the integrate-dm test seem to always fail (both this branch and master)

@xhebox
Copy link
Collaborator

xhebox commented Nov 7, 2025

@wuhuizuo I wanted to re-run the successful actions to re-try the upload to codecov. But that's now being fixed in #2639

Note that the integrate-dm test seem to always fail (both this branch and master)

Yeah, DM tests failed recently. And I dont know why exactly.

@dveeden dveeden force-pushed the playground__metafile branch from ba7f4ba to 972ed89 Compare November 7, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tiup status kills tiup playground

4 participants