-
Notifications
You must be signed in to change notification settings - Fork 381
Add repository data to the uploadthing package. #1221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
@gdborton is attempting to deploy a commit to the Ping Labs Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe package.json file for the "uploadthing" package was updated to add a "repository" field, specifying the repository type, URL, and directory. No changes were made to the codebase, dependencies, scripts, or exported entities. Changes
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/uploadthing/package.json (1)
9-13
: ```shell
#!/bin/bashDirectly read the repository field from package.json
jq '.repository' packages/uploadthing/package.json
</blockquote></details> </blockquote></details> <details> <summary>📜 Review details</summary> **Configuration used: CodeRabbit UI** **Review profile: CHILL** **Plan: Pro** <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between f79af3e62f6910586d5f5b69128fc89ef372058a and 34812438876222c5222d165b1807701c65975731. </details> <details> <summary>📒 Files selected for processing (1)</summary> * `packages/uploadthing/package.json` (1 hunks) </details> <details> <summary>🧰 Additional context used</summary> <details> <summary>🧠 Learnings (2)</summary> <details> <summary>📓 Common learnings</summary>
Learnt from: markflorkowski
PR: #978
File: examples/minimal-appdir/src/server/uploadthing.ts:62-62
Timestamp: 2024-10-03T20:03:58.906Z
Learning: In theonUploadComplete
handler inexamples/minimal-appdir/src/server/uploadthing.ts
, the return value{ foo: "bar" }
is intentionally a placeholder for user-defined logic and may represent database returns or other computed values.
Learnt from: markflorkowski
PR: #978
File: examples/minimal-appdir/src/server/uploadthing.ts:62-62
Timestamp: 2024-10-08T16:10:15.532Z
Learning: In theonUploadComplete
handler inexamples/minimal-appdir/src/server/uploadthing.ts
, the return value{ foo: "bar" }
is intentionally a placeholder for user-defined logic and may represent database returns or other computed values.
Learnt from: juliusmarminge
PR: #1013
File: packages/mime-types/package.json:24-69
Timestamp: 2024-11-05T17:11:33.300Z
Learning: In this codebase, the bundlerbunchee
usespackage.json
as the source of truth for exports and outputs matching files during the build process. Therefore, the export paths specified inpackage.json
align with the generated build output, even if the source files are located in asrc/
directory.</details> <details> <summary>packages/uploadthing/package.json (3)</summary>
Learnt from: juliusmarminge
PR: #1013
File: packages/mime-types/package.json:24-69
Timestamp: 2024-11-05T17:11:33.300Z
Learning: In this codebase, the bundlerbunchee
usespackage.json
as the source of truth for exports and outputs matching files during the build process. Therefore, the export paths specified inpackage.json
align with the generated build output, even if the source files are located in asrc/
directory.
Learnt from: markflorkowski
PR: #978
File: examples/minimal-appdir/src/server/uploadthing.ts:62-62
Timestamp: 2024-10-08T16:10:15.532Z
Learning: In theonUploadComplete
handler inexamples/minimal-appdir/src/server/uploadthing.ts
, the return value{ foo: "bar" }
is intentionally a placeholder for user-defined logic and may represent database returns or other computed values.
Learnt from: markflorkowski
PR: #978
File: examples/minimal-appdir/src/server/uploadthing.ts:62-62
Timestamp: 2024-10-03T20:03:58.906Z
Learning: In theonUploadComplete
handler inexamples/minimal-appdir/src/server/uploadthing.ts
, the return value{ foo: "bar" }
is intentionally a placeholder for user-defined logic and may represent database returns or other computed values.</details> </details> </details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
I was running into some trouble using the lib, and went to npm to see where I could potentially file an issue. Didn't see a repo there and assumed the lib was closed source... a random Google later and I found the repo. 👋
Summary by CodeRabbit