feat: update delete cell confirmation popup #1179
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: update delete cell confirmation popup * fix: Remove extra space if cell doesn't have a name * fix: Extract DataDocDeletePreview as a separate component Co-authored-by: Dave Bauman <[email protected]>
czgu
reviewed
Feb 24, 2023
| } | ||
| }; | ||
| if (shouldConfirm) { | ||
| let cellName = ''; |
Collaborator
There was a problem hiding this comment.
this part is same as
cellName = ` ${cell.meta.title ?? ''}`
Contributor
Author
There was a problem hiding this comment.
Structured this part in this way to avoid the below linting error.
Property 'title' does not exist on type 'IDataQueryCellMeta | IDataCellMetaBase | IDataChartCellMeta'.
Property 'title' does not exist on type 'IDataCellMetaBase'.
| export const DataDocDeletePreview: React.FunctionComponent<IProps> = ({ | ||
| cell, | ||
| }) => { | ||
| const [query, setQuery] = useState<string>(); |
Collaborator
There was a problem hiding this comment.
why do you need query as a state? vs
const query = cell.context as string
| cell: IDataCell; | ||
| } | ||
|
|
||
| export const DataDocDeletePreview: React.FunctionComponent<IProps> = ({ |
Collaborator
There was a problem hiding this comment.
probably don't need another component for this
Contributor
Author
There was a problem hiding this comment.
Responding to this and the previous comment, the separate component was added because without it CodeMirror wouldn't show the query contents when the delete confirmation first loaded. The fix we found was to force it to rerender by changing the state variable with useEffect, which isn't possible without a separate component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds more detail to the delete datadoc cell confirmation page to help users check which cell will be deleted. The confirmation page new details include the type of cell (text/query/chart), the name of the cell if it exists, and a query cell preview for query datadoc cells. This cell preview is uneditable, and shows a scroll bar for longer queries.
Currently the cell preview has a known issue where queries less than 10 lines will overlap with the query line count, depicted in the below screenshot. We were unable to fix this overlap, but otherwise the cell preview works as expected.