Obey Transport protocol #366
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fantastic work @swagggpickle this looks right to me. I will double check some stuff and then merge this ASAP :) Mind adding yourself to the README? |
Codecov Report
@@ Coverage Diff @@
## master #366 +/- ##
==========================================
- Coverage 78.49% 78.24% -0.26%
==========================================
Files 33 33
Lines 2581 2583 +2
==========================================
- Hits 2026 2021 -5
- Misses 388 396 +8
+ Partials 167 166 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@Sean-Der Sure thing I will add myself to the README. I will also add to the unit test to ensure coverage. |
zyxar
reviewed
May 6, 2021
|
@Sean-Der Hi, Do you have a status update? |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The purpose of this PR is to add a check for transportation protocol before attempting to connect via UDP to server.
Using the latest version of
coturnimplementation with theno-udpflag specified and a strict firewall preventing UDP traffic one would observe that the ice candidate gathering takes 5 seconds. After some investigation I found that thetransport=tcpflag was not being obeyed within thegatherCandidatesSrflxfunction.Related issue
#367