Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #309 +/- ##
==========================================
- Coverage 79.69% 79.45% -0.25%
==========================================
Files 82 84 +2
Lines 4063 4176 +113
==========================================
+ Hits 3238 3318 +80
- Misses 659 685 +26
- Partials 166 173 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c12a5b4 to
6f6187a
Compare
bfc0780 to
808eb87
Compare
| } | ||
|
|
||
| func (i *Interceptor) loop() { | ||
| ticker := time.NewTicker(i.interval) |
There was a problem hiding this comment.
We don't seem to be calling ticker.Stop()
There was a problem hiding this comment.
I added a defer ticker.Stop(), although I don't think we necessarily need it since Go 1.23, because the ticker should be garbage collected when it is unreferenced, even without calling Stop. At least that's how I understand the documentation.
There was a problem hiding this comment.
I read about this, sadly. it's going to be a while before we can drop go 1.22 and 1.21 in pion, also the new behavior is eligible for collection immediately, and it doesn't say that it’s collected immediately, at least from my understanding, but i didn't test it.
Thanks.
fa8021f to
8a125e2
Compare
8a125e2 to
4d47254
Compare
Description
Implements a pacing interceptor separate from congestion control. The interceptor calls back to implementations of the
Pacerinterface whenever a packet is sent.