Conversation
Fixes pion#221 As previously discussed, the pkg directory is not used in Pion projects.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #237 +/- ##
=======================================
Coverage 87.38% 87.38%
=======================================
Files 20 20
Lines 1887 1887
=======================================
Hits 1649 1649
Misses 207 207
Partials 31 31
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sean-Der
approved these changes
Aug 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As previously discussed, the pkg directory is not used in Pion projects.
This maintains compatibility with existing code and adds a deprecation notice to the old objects.
Reference issue
Fixes #221