Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade golangci-lint, more linters #362

Merged
merged 1 commit into from
Jan 25, 2025
Merged

Upgrade golangci-lint, more linters #362

merged 1 commit into from
Jan 25, 2025

Conversation

JoeTurki
Copy link
Member

Description

Introduces new linters, upgrade golangci-lint to version (v1.63.4)

Reference issue

pion/.goassets#220

@JoeTurki JoeTurki mentioned this pull request Jan 25, 2025
20 tasks
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 90.65817% with 44 lines in your changes missing coverage. Please review.

Project coverage is 81.88%. Comparing base (c01e593) to head (f193005).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
association.go 90.20% 15 Missing and 14 partials ⚠️
pending_queue.go 54.54% 0 Missing and 5 partials ⚠️
chunk_init_ack.go 20.00% 4 Missing ⚠️
param_heartbeat_info.go 0.00% 2 Missing ⚠️
stream.go 90.47% 2 Missing ⚠️
error_cause.go 87.50% 0 Missing and 1 partial ⚠️
packet.go 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #362      +/-   ##
==========================================
+ Coverage   81.70%   81.88%   +0.17%     
==========================================
  Files          51       51              
  Lines        4384     4532     +148     
==========================================
+ Hits         3582     3711     +129     
- Misses        660      678      +18     
- Partials      142      143       +1     
Flag Coverage Δ
go 81.88% <90.65%> (+0.17%) ⬆️
wasm 67.76% <75.37%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Introduces new linters, upgrade golangci-lint to version (v1.63.4)
@JoeTurki JoeTurki merged commit f193005 into master Jan 25, 2025
13 checks passed
@JoeTurki JoeTurki deleted the impr/lint branch January 25, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant