Skip to content

Added SCTPTransport.BufferedAmount #3096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

sirzooro
Copy link
Contributor

It simplifies tracking amount of unsent data for all data channels, including ones in closing state. Especially useful for IoT apps which use multiple data channels and have to monitor memory usage.

Copy link

codecov bot commented Apr 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 78.76%. Comparing base (3e43ae9) to head (9c5f589).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
sctptransport.go 0.00% 7 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3096      +/-   ##
==========================================
+ Coverage   78.67%   78.76%   +0.09%     
==========================================
  Files          91       91              
  Lines       11340    11347       +7     
==========================================
+ Hits         8922     8938      +16     
+ Misses       1929     1924       -5     
+ Partials      489      485       -4     
Flag Coverage Δ
go 80.67% <0.00%> (+0.09%) ⬆️
wasm 63.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

It simplifies tracking amount of unsent data for all data channels,
including ones in closing state. Especially useful for IoT apps
which use multiple data channels and have to monitor memory usage.
@sirzooro sirzooro force-pushed the add_sctp_bufferedamount branch from af7d5e2 to 9c5f589 Compare April 13, 2025 12:42
@sirzooro sirzooro requested review from edaniels and JoeTurki April 13, 2025 12:47
@JoeTurki JoeTurki added this to the V4.1.0 milestone Apr 13, 2025
@sirzooro sirzooro merged commit c79463d into pion:master Apr 14, 2025
16 of 17 checks passed
@sirzooro sirzooro deleted the add_sctp_bufferedamount branch April 14, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants