Add WithRTPTimestamp to set initial RTP timestamp #3112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeTurki
commented
Apr 26, 2025
| @@ -69,6 +70,13 @@ func WithPayloader(h func(RTPCodecCapability) (rtp.Payloader, error)) func(*Trac | |||
| } | |||
| } | |||
|
|
|||
| // WithRTPTimestamp set the initial RTP timestamp for the track. | |||
| func WithRTPTimestamp(timestamp uint32) func(*TrackLocalStaticRTP) { | |||
There was a problem hiding this comment.
I'm not sure about the name!
There was a problem hiding this comment.
Name sounds good to me! I know exactly what it does and I can google 'RTP Timestamp' if I am confused :)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3112 +/- ##
==========================================
+ Coverage 78.72% 78.77% +0.05%
==========================================
Files 91 91
Lines 11373 11383 +10
==========================================
+ Hits 8953 8967 +14
+ Misses 1933 1932 -1
+ Partials 487 484 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JoeTurki
force-pushed
the
with-rtp-timestamp
branch
from
e4edd96 to
1d080a4
Compare
Move to the new RTP API newPacketizerWithOptions, add WithRTPTimestamp To make it possible to set the initial RTP timestamp for the track.
JoeTurki
force-pushed
the
with-rtp-timestamp
branch
from
1d080a4 to
d6154f6
Compare
Sean-Der
approved these changes
Apr 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move to the new RTP API newPacketizerWithOptions, add WithRTPTimestamp To make it possible to set the initial RTP timestamp for the track.
Reference issue
Fixes pion/rtp#111