Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add Google Tag Manager to the site (#4519)" #4531

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

kentakozuka
Copy link
Member

This reverts commit 824f9c0.

I read the docs and realized we can do what we want only by using the GA tag.

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (faf178f) 30.00% compared to head (cfa7178) 30.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4531   +/-   ##
=======================================
  Coverage   30.00%   30.00%           
=======================================
  Files         220      220           
  Lines       25808    25808           
=======================================
  Hits         7743     7743           
  Misses      17418    17418           
  Partials      647      647           

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khanhtc1202 khanhtc1202 merged commit ec01b39 into pipe-cd:master Jul 31, 2023
13 checks passed
@kentakozuka kentakozuka deleted the revert-gtm branch July 31, 2023 11:59
@github-actions github-actions bot mentioned this pull request Aug 23, 2023
sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request Aug 27, 2023
)

This reverts commit 824f9c0.

Signed-off-by: Kenta Kozuka <[email protected]>
Signed-off-by: sZma5a <[email protected]>
moko-poi pushed a commit to moko-poi/pipecd that referenced this pull request Nov 3, 2023
)

This reverts commit 824f9c0.

Signed-off-by: Kenta Kozuka <[email protected]>
Signed-off-by: moko-poi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants