fix: ECS WaitService finish before task running #4568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tokku5552
requested review from
nghialv,
khanhtc1202 and
kentakozuka
as code owners
|
@tokku5552 Thanks for contribution, please use |
khanhtc1202
reviewed
Aug 25, 2023
tokku5552
force-pushed
the
fix-ecs-stable-waiting
branch
from
8185c26
to
5c3e703
Compare
tokku5552
force-pushed
the
fix-ecs-stable-waiting
branch
2 times, most recently
from
3c1a856
to
f650075
Compare
Signed-off-by: 徳田 真之介 <[email protected]>
Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: 徳田 真之介 <[email protected]>
tokku5552
force-pushed
the
fix-ecs-stable-waiting
branch
from
8898cf7
to
9892069
Compare
khanhtc1202
approved these changes
Aug 25, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #4568 +/- ##
==========================================
+ Coverage 29.91% 29.94% +0.02%
==========================================
Files 220 220
Lines 25873 25877 +4
==========================================
+ Hits 7741 7749 +8
+ Misses 17484 17481 -3
+ Partials 648 647 -1
☔ View full report in Codecov by Sentry. |
khanhtc1202
added a commit
that referenced
this pull request
Aug 25, 2023
* fix: ECS WaitService finish before task running Signed-off-by: 徳田 真之介 <[email protected]> * Update pkg/app/piped/platformprovider/ecs/client.go Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: 徳田 真之介 <[email protected]> --------- Signed-off-by: 徳田 真之介 <[email protected]> Co-authored-by: Khanh Tran <[email protected]>
khanhtc1202
added a commit
that referenced
this pull request
Aug 25, 2023
* Support create ECS service with serviceRegistries configuration (#4564) Signed-off-by: khanhtc1202 <[email protected]> * Support update service which contains serviceRegistries (#4567) Signed-off-by: khanhtc1202 <[email protected]> * fix: ECS WaitService finish before task running (#4568) * fix: ECS WaitService finish before task running Signed-off-by: 徳田 真之介 <[email protected]> * Update pkg/app/piped/platformprovider/ecs/client.go Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: 徳田 真之介 <[email protected]> --------- Signed-off-by: 徳田 真之介 <[email protected]> Co-authored-by: Khanh Tran <[email protected]> --------- Signed-off-by: khanhtc1202 <[email protected]> Signed-off-by: 徳田 真之介 <[email protected]> Co-authored-by: tokku5552 <[email protected]>
moko-poi
pushed a commit
to moko-poi/pipecd
that referenced
this pull request
Nov 3, 2023
* fix: ECS WaitService finish before task running Signed-off-by: 徳田 真之介 <[email protected]> * Update pkg/app/piped/platformprovider/ecs/client.go Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: 徳田 真之介 <[email protected]> --------- Signed-off-by: 徳田 真之介 <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: moko-poi <[email protected]>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixed an issue where ECS tasks were marked as successful before they were all started
Which issue(s) this PR fixes:
Follow PR #4548
Does this PR introduce a user-facing change?: