Improve: add deployment timestamp in webhook #4591
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GotoRen
requested review from
nghialv,
khanhtc1202 and
kentakozuka
as code owners
Signed-off-by: GotoRen <[email protected]>
GotoRen
force-pushed
the
improve-deploy-timestamp-notification
branch
from
b7463f7
to
cf26856
Compare
|
@GotoRen Sorry for being so late to review! |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
This PR was closed because it has been stalled for 7 days with no activity. Feel free to reopen if still applicable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Including in PipeCD webhook the timestamp when an existing resource was changed by piped.
PipeCD gets the deployment status by reportDeploymentCompleted. At this time, a timestamp (CompletedAt) of when the status was obtained is included in PipeCD webhook.
We can know precisely the timing of the deployment by obtaining the timestamp when receiving the apply result of the manifests.
Which issue(s) this PR fixes:
Fixes #4584
Does this PR introduce a user-facing change?: