Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service tags as takset tags on create #4598

Merged
merged 1 commit into from
Sep 10, 2023
Merged

Conversation

khanhtc1202
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (06b38f3) 29.98% compared to head (c0d2a0d) 29.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4598      +/-   ##
==========================================
- Coverage   29.98%   29.98%   -0.01%     
==========================================
  Files         220      220              
  Lines       25948    25949       +1     
==========================================
  Hits         7781     7781              
- Misses      17518    17519       +1     
  Partials      649      649              
Files Changed Coverage Δ
pkg/app/piped/platformprovider/ecs/client.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@khanhtc1202 khanhtc1202 changed the title Add service tags as takset task on create Add service tags as takset tags on create Sep 8, 2023
Copy link
Member

@kentakozuka kentakozuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@khanhtc1202 khanhtc1202 merged commit afc4ac5 into master Sep 10, 2023
12 of 14 checks passed
@khanhtc1202 khanhtc1202 deleted the update-taskset-tag branch September 10, 2023 23:46
khanhtc1202 added a commit that referenced this pull request Oct 11, 2023
khanhtc1202 added a commit that referenced this pull request Oct 11, 2023
* Display MySQL user defined error in API Key UI (#4590)

* Display MySQL user defined error in UI

Signed-off-by: Kenta Kozuka <[email protected]>

* Fix Unexpected empty arrow function

Signed-off-by: Kenta Kozuka <[email protected]>

* Add tests

Signed-off-by: Kenta Kozuka <[email protected]>

* Run subtests in parallel

Signed-off-by: Kenta Kozuka <[email protected]>

---------

Signed-off-by: Kenta Kozuka <[email protected]>

* Display MySQL user defined error of piped, command, and application (#4597)

Signed-off-by: Kenta Kozuka <[email protected]>

* Add service tags as takset task on create (#4598)

Signed-off-by: khanhtc1202 <[email protected]>

* [ECS] Fix remove all previous active tasksets on QuickSync (#4600)

* Remove previous ACTIVE tasksets if present on quicksync

Signed-off-by: khanhtc1202 <[email protected]>

* Remove GetPrimaryTaskSet interface

Signed-off-by: khanhtc1202 <[email protected]>

---------

Signed-off-by: khanhtc1202 <[email protected]>

* Fix unable to fetch ECS taskset tags (#4605)

Signed-off-by: khanhtc1202 <[email protected]>

* Support recreate for ECS tasks (#4608)

* Support singleton ECS task

Signed-off-by: khanhtc1202 <[email protected]>

* Rename singleton to recreate

Signed-off-by: khanhtc1202 <[email protected]>

---------

Signed-off-by: khanhtc1202 <[email protected]>

---------

Signed-off-by: Kenta Kozuka <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
Co-authored-by: Kenta Kozuka <[email protected]>
moko-poi pushed a commit to moko-poi/pipecd that referenced this pull request Nov 3, 2023
sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request Nov 5, 2023
@github-actions github-actions bot mentioned this pull request Dec 1, 2023
@github-actions github-actions bot mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants