-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use repository settings from piped config #4739
Conversation
989d485
to
530752a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4739 +/- ##
==========================================
- Coverage 30.84% 30.82% -0.02%
==========================================
Files 222 221 -1
Lines 26037 26011 -26
==========================================
- Hits 8032 8019 -13
+ Misses 17355 17342 -13
Partials 650 650 ☔ View full report in Codecov by Sentry. |
530752a
to
7a28859
Compare
Thank you for the PR :) Actually, this change may affect the behavior of executing the pipeline. |
📝 We should investigate the effect because some features including Deployment are based on the information of Application.GtiPath. |
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Signed-off-by: golemiso <[email protected]>
Signed-off-by: golemiso <[email protected]>
e510aa5
to
dab442a
Compare
refactored: override repository with piped config (decent one) when creating deployment. |
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This PR was closed because it has been stalled for 7 days with no activity. Feel free to reopen if still applicable. |
#5328 is a better solution for this |
What this PR does / why we need it:
Remote
andBranch
because repository settings in app config metadata are not reliable (they can be outdated by modifying piped config)Which issue(s) this PR fixes:
Fixes #4618
Does this PR introduce a user-facing change?: