Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init rfc for piped plugin arch #5285

Merged
merged 7 commits into from
Oct 23, 2024
Merged

Init rfc for piped plugin arch #5285

merged 7 commits into from
Oct 23, 2024

Conversation

khanhtc1202
Copy link
Member

What this PR does:

Why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.37%. Comparing base (23ca1b3) to head (15b017c).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5285      +/-   ##
==========================================
+ Coverage   24.31%   24.37%   +0.06%     
==========================================
  Files         440      442       +2     
  Lines       46784    46902     +118     
==========================================
+ Hits        11374    11432      +58     
- Misses      34507    34560      +53     
- Partials      903      910       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your great RFC.
I commented on some nit + suggested additions.

docs/rfcs/0015-pipecd-plugin-arch-meta.md Outdated Show resolved Hide resolved
docs/rfcs/0015-pipecd-plugin-arch-meta.md Outdated Show resolved Hide resolved
docs/rfcs/0015-pipecd-plugin-arch-meta.md Outdated Show resolved Hide resolved
docs/rfcs/0015-pipecd-plugin-arch-meta.md Show resolved Hide resolved
docs/rfcs/0015-pipecd-plugin-arch-meta.md Show resolved Hide resolved
docs/rfcs/0015-pipecd-plugin-arch-meta.md Outdated Show resolved Hide resolved
docs/rfcs/0015-pipecd-plugin-arch-meta.md Outdated Show resolved Hide resolved
docs/rfcs/0015-pipecd-plugin-arch-meta.md Outdated Show resolved Hide resolved
docs/rfcs/0015-pipecd-plugin-arch-meta.md Outdated Show resolved Hide resolved
khanhtc1202 and others added 6 commits October 21, 2024 16:38
Co-authored-by: Tetsuya Kikuchi <[email protected]>
Signed-off-by: Khanh Tran <[email protected]>
Co-authored-by: Tetsuya Kikuchi <[email protected]>
Signed-off-by: Khanh Tran <[email protected]>
Co-authored-by: Tetsuya Kikuchi <[email protected]>
Signed-off-by: Khanh Tran <[email protected]>
Co-authored-by: Tetsuya Kikuchi <[email protected]>
Signed-off-by: Khanh Tran <[email protected]>
Co-authored-by: Tetsuya Kikuchi <[email protected]>
Signed-off-by: Khanh Tran <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@khanhtc1202 khanhtc1202 merged commit 4f5446c into master Oct 23, 2024
18 checks passed
@khanhtc1202 khanhtc1202 deleted the rfc-plugin-arch branch October 23, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants