-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init rfc for piped plugin arch #5285
Conversation
Signed-off-by: khanhtc1202 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5285 +/- ##
==========================================
+ Coverage 24.31% 24.37% +0.06%
==========================================
Files 440 442 +2
Lines 46784 46902 +118
==========================================
+ Hits 11374 11432 +58
- Misses 34507 34560 +53
- Partials 903 910 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your great RFC.
I commented on some nit + suggested additions.
Co-authored-by: Tetsuya Kikuchi <[email protected]> Signed-off-by: Khanh Tran <[email protected]>
Co-authored-by: Tetsuya Kikuchi <[email protected]> Signed-off-by: Khanh Tran <[email protected]>
Co-authored-by: Tetsuya Kikuchi <[email protected]> Signed-off-by: Khanh Tran <[email protected]>
Co-authored-by: Tetsuya Kikuchi <[email protected]> Signed-off-by: Khanh Tran <[email protected]>
Co-authored-by: Tetsuya Kikuchi <[email protected]> Signed-off-by: Khanh Tran <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
What this PR does:
Why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: