Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): "Edit this page" URLs to correctly point to GitHub repository structure #5289

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

ntheanh201
Copy link
Contributor

What this PR does:
This PR fixes the "Edit this page" URLs in the documentation pages to correctly point to the appropriate locations in the GitHub repository structure.
Why we need it:
The current "Edit this page" URLs are incorrect, pointing to a wrong path in the repository (missing .md extension).
Which issue(s) this PR fixes:

Fixes #5287

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@t-kikuc
Copy link
Member

t-kikuc commented Oct 23, 2024

@ntheanh201
Thank you so much.
Would you commit with -s to pass the DCO check?

cf. https://github.com/pipe-cd/pipecd/pull/5289/checks?check_run_id=31926903751

Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@t-kikuc t-kikuc enabled auto-merge (squash) October 23, 2024 07:14
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you 👍

@t-kikuc t-kikuc merged commit c265522 into pipe-cd:master Oct 23, 2024
15 checks passed
@ntheanh201 ntheanh201 deleted the fix/docs branch October 23, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot navigate to the edit page even after clicking "Edit this page".
3 participants