Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move model.DeploymentSource to deployment.DeploymentSource #5290

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Oct 23, 2024

What this PR does:

as title.

Why we need it:

I don't want plugins to depend directly on pkg/model.

Both pipedv1 and plugins depend on DeploymentSource, so I moved it.

Dependencies remain in Go codes because proto files under pkg/plugin depend on pkg/model, and the plugin has to build its structs to return them as the gRPC responses.

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 24.36%. Comparing base (2c02136) to head (8f73a7c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/controller/planner.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5290      +/-   ##
==========================================
- Coverage   24.37%   24.36%   -0.02%     
==========================================
  Files         442      442              
  Lines       46902    46902              
==========================================
- Hits        11432    11426       -6     
- Misses      34560    34566       +6     
  Partials      910      910              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Warashi Warashi merged commit db18917 into master Oct 23, 2024
15 of 18 checks passed
@Warashi Warashi deleted the pipedv1-deploymentsource-not-model branch October 23, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants