Move model.DeploymentSource to deployment.DeploymentSource #5290
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title.
Why we need it:
I don't want plugins to depend directly on
pkg/model
.Both pipedv1 and plugins depend on
DeploymentSource,
so I moved it.Dependencies remain in Go codes because proto files under
pkg/plugin
depend onpkg/model
, and the plugin has to build its structs to return them as the gRPC responses.Which issue(s) this PR fixes:
Part of #4980
Does this PR introduce a user-facing change?: No