Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort trailers to ensure the order #5334

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Sort trailers to ensure the order #5334

merged 2 commits into from
Nov 14, 2024

Conversation

ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented Nov 14, 2024

What this PR does:

Sort trailers before commit with them to ensure the order.

Why we need it:

Which issue(s) this PR fixes:

Part of #5028

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Yoshiki Fujikane <[email protected]>
@khanhtc1202
Copy link
Member

@ffjlabo Go build and test failed, maybe caused by the CI go version 👀

@ffjlabo
Copy link
Member Author

ffjlabo commented Nov 14, 2024

@khanhtc1202 Sorry, it seems that these feature are supported from Go 1.23. So I will rewrite it with Go 1.22 syntax for now.

Signed-off-by: Yoshiki Fujikane <[email protected]>
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.31%. Comparing base (1763f92) to head (6594052).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5334      +/-   ##
==========================================
+ Coverage   25.28%   25.31%   +0.02%     
==========================================
  Files         444      444              
  Lines       47574    47601      +27     
==========================================
+ Hits        12028    12049      +21     
- Misses      34603    34609       +6     
  Partials      943      943              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ffjlabo
Copy link
Member Author

ffjlabo commented Nov 14, 2024

@khanhtc1202 Updated at 6594052 🙏

Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ffjlabo ffjlabo merged commit d4cdb13 into master Nov 14, 2024
18 checks passed
@ffjlabo ffjlabo deleted the ensure-order-of-trailer branch November 14, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants