-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort trailers to ensure the order #5334
Conversation
Signed-off-by: Yoshiki Fujikane <[email protected]>
@ffjlabo Go build and test failed, maybe caused by the CI go version 👀 |
@khanhtc1202 Sorry, it seems that these feature are supported from Go 1.23. So I will rewrite it with Go 1.22 syntax for now. |
Signed-off-by: Yoshiki Fujikane <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5334 +/- ##
==========================================
+ Coverage 25.28% 25.31% +0.02%
==========================================
Files 444 444
Lines 47574 47601 +27
==========================================
+ Hits 12028 12049 +21
- Misses 34603 34609 +6
Partials 943 943 ☔ View full report in Codecov by Sentry. |
@khanhtc1202 Updated at 6594052 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does:
Sort trailers before commit with them to ensure the order.
Why we need it:
Which issue(s) this PR fixes:
Part of #5028
Does this PR introduce a user-facing change?: