Add notification event DEPLOYMENT_STARTED #5340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Warashi
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo and
t-kikuc
as code owners
Warashi
commented
Nov 15, 2024
Comment on lines
+67
to
+71
| message NotificationEventDeploymentStarted { | ||
| Deployment deployment = 1 [(validate.rules).message.required = true]; | ||
| repeated string mentioned_accounts = 3; | ||
| repeated string mentioned_groups = 4; | ||
| } |
There was a problem hiding this comment.
I skipped field No. 2 because other codes skipped it.
I don't know why, but I think it's better to do the same as the other codes.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5340 +/- ##
==========================================
- Coverage 25.31% 25.31% -0.01%
==========================================
Files 444 444
Lines 47601 47641 +40
==========================================
+ Hits 12049 12059 +10
- Misses 34609 34640 +31
+ Partials 943 942 -1 ☔ View full report in Codecov by Sentry. |
khanhtc1202
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title
The users can receive notification when the deployments started.
I tested with Slack notification.
Why we need it:
I want to know when the Deployment status changed to RUNNING.
Which issue(s) this PR fixes:
Part of #2002
Does this PR introduce a user-facing change?: Yes
How are users affected by this change:
Users can configure the piped to send notifications when deployments start.
Is this breaking change: No
How to migrate (if breaking change): N/A