Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frames: added metadata field to Frame class #1110

Merged
merged 1 commit into from
Jan 29, 2025
Merged

frames: added metadata field to Frame class #1110

merged 1 commit into from
Jan 29, 2025
+7 −1

Conversation

aconchillo
Copy link
Contributor

Please describe the changes in your PR. If it is addressing an issue, please reference that as well.

Added a metadata field to Frame which makes it possible to pass custom data to all frames.

filipi87
filipi87 approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@filipi87 filipi87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
I assume the best way to pass the metadata to the next frame is still being determined, so we’ll handle that in a future PR, right?

@aconchillo
Copy link
Contributor Author

Looks good! I assume the best way to pass the metadata to the next frame is still being determined, so we’ll handle that in a future PR, right?

Yes, that's right. We need to give that more thought.

@aconchillo aconchillo merged commit 4ff68e6 into main Jan 29, 2025
4 checks passed
@aconchillo aconchillo deleted the aleix/frame-metadata branch January 29, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipi87 filipi87 filipi87 approved these changes

@chadbailey59 chadbailey59 Awaiting requested review from chadbailey59

@markbackman markbackman Awaiting requested review from markbackman

@kwindla kwindla Awaiting requested review from kwindla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aconchillo @filipi87