-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor simli updates #814
minor simli updates #814
Conversation
src/pipecat/services/simli.py
Outdated
from loguru import logger | ||
|
||
try: | ||
from av import AudioFrame |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like AudioFrame needs to be imported from
av.audio.frame`. My IDE was complaining otherwise.
from av import AudioFrame | |
from av.audio.frame import AudioFrame |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
I'm experiencing crackling audio when the bot starts speaking. And I get this error line in the logs which scrolls continuously:
In comparing to the current version on main, this one runs, so that's good! It would be ideal to sort of this issue. We can merge this and just open an issue if the problem isn't obvious. |
d2b7706
to
d7b6a00
Compare
Sometimes I also get two audio stream outputs that happen offset and concurrently. Have you seen that? |
76e3eb8
to
02d8b95
Compare
Yes, my bad. Just fixed it. The way this works is: Pipecat sends audio to Simli and then Simli sends audio back that is synchronized with the video and that's the one we send to the transport. The only issue is that the bot is always speaking since we are always getting audio (silence though...). |
Do we want to move forward with this? On one hand, the current version that's on main is not working. On the other, this isn't performing well, at least for me. Maybe we merge it and revisit the colorspace acceleration issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving to fix main. @aconchillo can you add an issue to track improving this one?
02d8b95
to
5b478a5
Compare
You mean this one, right?
|
That's right |
Added #825 I believe it's the the ffmpeg build on PyAV for macOS (which simli uses). I don't have this issue on Linux. |
Please describe the changes in your PR. If it is addressing an issue, please reference that as well.