Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor simli updates #814

Merged
merged 3 commits into from
Dec 11, 2024
Merged

minor simli updates #814

merged 3 commits into from
Dec 11, 2024

Conversation

aconchillo
Copy link
Contributor

Please describe the changes in your PR. If it is addressing an issue, please reference that as well.

from loguru import logger

try:
from av import AudioFrame
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like AudioFrame needs to be imported from av.audio.frame`. My IDE was complaining otherwise.

Suggested change
from av import AudioFrame
from av.audio.frame import AudioFrame

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@markbackman
Copy link
Contributor

I'm experiencing crackling audio when the bot starts speaking. And I get this error line in the logs which scrolls continuously:

[swscaler @ 0x148008000] No accelerated colorspace conversion found from yuv420p to rgb24.

In comparing to the current version on main, this one runs, so that's good!

It would be ideal to sort of this issue. We can merge this and just open an issue if the problem isn't obvious.

@markbackman
Copy link
Contributor

Sometimes I also get two audio stream outputs that happen offset and concurrently. Have you seen that?

@aconchillo aconchillo force-pushed the aleix/simli-updates branch 2 times, most recently from 76e3eb8 to 02d8b95 Compare December 10, 2024 19:31
@aconchillo
Copy link
Contributor Author

aconchillo commented Dec 10, 2024

Sometimes I also get two audio stream outputs that happen offset and concurrently. Have you seen that?

Yes, my bad. Just fixed it. The way this works is: Pipecat sends audio to Simli and then Simli sends audio back that is synchronized with the video and that's the one we send to the transport. The only issue is that the bot is always speaking since we are always getting audio (silence though...).

@markbackman
Copy link
Contributor

Do we want to move forward with this? On one hand, the current version that's on main is not working. On the other, this isn't performing well, at least for me. Maybe we merge it and revisit the colorspace acceleration issue?

Copy link
Contributor

@markbackman markbackman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving to fix main. @aconchillo can you add an issue to track improving this one?

@aconchillo
Copy link
Contributor Author

I'm approving to fix main. @aconchillo can you add an issue to track improving this one?

You mean this one, right?

[swscaler @ 0x148008000] No accelerated colorspace conversion found from yuv420p to rgb24.

@markbackman
Copy link
Contributor

I'm approving to fix main. @aconchillo can you add an issue to track improving this one?

You mean this one, right?

[swscaler @ 0x148008000] No accelerated colorspace conversion found from yuv420p to rgb24.

That's right

@aconchillo aconchillo merged commit 62ec2f5 into main Dec 11, 2024
3 checks passed
@aconchillo aconchillo deleted the aleix/simli-updates branch December 11, 2024 02:48
@aconchillo
Copy link
Contributor Author

I'm approving to fix main. @aconchillo can you add an issue to track improving this one?

You mean this one, right?

[swscaler @ 0x148008000] No accelerated colorspace conversion found from yuv420p to rgb24.

That's right

Added #825

I believe it's the the ffmpeg build on PyAV for macOS (which simli uses). I don't have this issue on Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants