Fixes #4113 - Update CDI TCK to 4.1.0 (#4114)

piranhacloud · Oct 24, 2024 · 17a7869 · 17a7869
1 parent e3dd5c4
commit 17a7869
Show file tree

Hide file tree

Showing 22 changed files with 47 additions and 36 deletions.
diff --git a/.github/workflows/tck-coreprofile.yml b/.github/workflows/tck-coreprofile.yml
@@ -49,12 +49,14 @@ jobs:
       run: mvn -B -DskipTests=true -ntp install
     - name: Run TCK
       run: |
-        cd external/coreprofile-tck/cdi
+        cd external/tck/cdi
         mvn -B -ntp -T 1 verify
     - name: Test Summary
       uses: test-summary/action@v2
       with:
-        paths: "external/coreprofile-tck/cdi/runner/target/surefire-reports/junitreports/TEST-*.xml"
+        paths: |
+          external/tck/cdi/runner/core/target/surefire-reports/junit-reports/TEST-*.xml
+          external/tck/cdi/runner/model/target/surefire-reports/TEST-*.xml
       if: always()
   coreprofile:
     if: github.repository == 'piranhacloud/piranha'
@@ -159,8 +161,8 @@ jobs:
       uses: test-summary/action@v2
       with:
         paths: |
-          external/tck/jsonb/installer/target/tck/bin/tck-tests/target/surefire-reports/TEST-*.xml
-          external/tck/jsonb/installer/target/tck/bin/tck-tests-pluggability/target/surefire-reports/TEST-*.xml
+          external/tck/jsonp/installer/target/tck/bin/tck-tests/target/surefire-reports/TEST-*.xml
+          external/tck/jsonp/installer/target/tck/bin/tck-tests-pluggability/target/surefire-reports/TEST-*.xml
       if: always()
   rest:
     if: github.repository == 'piranhacloud/piranha'

diff --git a/external/coreprofile-tck/pom.xml b/external/coreprofile-tck/pom.xml
@@ -16,17 +16,13 @@
     <name>Piranha Core Profile - Core Profile TCK project</name>
 
     <modules>
-        <module>cdi</module>
         <module>coreprofile</module>
         <module>rest</module>
     </modules>
 
     <properties>
         <!-- TCK versions -->
-        <cdi.tck.version>4.0.13</cdi.tck.version>
         <coreprofile.tck.version>10.0.3</coreprofile.tck.version>
         <rest.tck.version>3.1.5</rest.tck.version>
-        <!-- Implementation versions -->
-        <weld.version>6.0.0.Beta4</weld.version>
     </properties>
 </project>
diff --git a/...nal/coreprofile-tck/cdi/installer/pom.xml → external/tck/cdi/installer/pom.xml b/...nal/coreprofile-tck/cdi/installer/pom.xml → external/tck/cdi/installer/pom.xml
@@ -4,15 +4,15 @@
     <modelVersion>4.0.0</modelVersion>
 
     <parent>
-        <groupId>cloud.piranha.external.coreprofiletck.cditck</groupId>
+        <groupId>cloud.piranha.external.tck.cdi</groupId>
         <artifactId>project</artifactId>
         <version>24.11.0-SNAPSHOT</version>
     </parent>
 
-    <artifactId>installer</artifactId>
+    <artifactId>piranha-external-tck-cdi-installer</artifactId>
     <packaging>pom</packaging>
 
-    <name>Piranha Core Profile - CDI TCK - Installer</name>
+    <name>Piranha - External - TCK - CDI - Installer</name>
 
     <dependencyManagement>
         <dependencies>
@@ -41,7 +41,7 @@
                         <configuration>
                             <target>
                                 <!-- Download, unzip and rename TCK -->
-                                <get src="https://download.eclipse.org/jakartaee/cdi/4.0/cdi-tck-${cdi.tck.version}-dist.zip"
+                                <get src="https://download.eclipse.org/jakartaee/cdi/4.1/cdi-tck-${cdi.tck.version}-dist.zip"
                                      dest="${project.build.directory}/tck.zip"
                                      skipexisting="true"/>
                                 <unzip src="${project.build.directory}/tck.zip"

diff --git a/external/coreprofile-tck/cdi/pom.xml → external/tck/cdi/pom.xml b/external/coreprofile-tck/cdi/pom.xml → external/tck/cdi/pom.xml
@@ -4,16 +4,20 @@
     <modelVersion>4.0.0</modelVersion>
 
     <parent>
-        <groupId>cloud.piranha.external.coreprofiletck</groupId>
+        <groupId>cloud.piranha.external.tck</groupId>
         <artifactId>project</artifactId>
         <version>24.11.0-SNAPSHOT</version>
     </parent>
 
-    <groupId>cloud.piranha.external.coreprofiletck.cditck</groupId>
+    <groupId>cloud.piranha.external.tck.cdi</groupId>
     <artifactId>project</artifactId>
     <packaging>pom</packaging>
 
-    <name>Piranha Core Profile - CDI TCK - Project</name>
+    <name>Piranha - External - TCK - CDI - Project</name>
+
+    <properties>
+        <cdi.tck.version>4.1.0</cdi.tck.version>
+    </properties>
 
     <modules>
         <module>installer</module>

diff --git a/...l/coreprofile-tck/cdi/runner/core/pom.xml → external/tck/cdi/runner/core/pom.xml b/...l/coreprofile-tck/cdi/runner/core/pom.xml → external/tck/cdi/runner/core/pom.xml
@@ -1,16 +1,18 @@
 <?xml version="1.0" encoding="UTF-8"?>
+
 <project xmlns="http://maven.apache.org/POM/4.0.0"
     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
     xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <modelVersion>4.0.0</modelVersion>
     <parent>
-        <groupId>cloud.piranha.external.coreprofiletck.cditck.runner</groupId>
+        <groupId>cloud.piranha.external.tck.cdi.runner</groupId>
         <artifactId>project</artifactId>
         <version>24.11.0-SNAPSHOT</version>
     </parent>
-    <artifactId>core</artifactId>
 
-    <name>Piranha Core Profile - CDI TCK - Runner - Core</name>
+    <artifactId>piranha-external-tck-cdi-runner-core</artifactId>
+
+    <name>Piranha - External - TCK - CDI - Runner - Core</name>
 
     <properties>
         <piranha.version>${project.version}</piranha.version>

diff --git a/...iranhaDeploymentExceptionTransformer.java → ...iranhaDeploymentExceptionTransformer.java b/...iranhaDeploymentExceptionTransformer.java → ...iranhaDeploymentExceptionTransformer.java
diff --git a/...ss/weld/tck/piranha/PiranhaExtension.java → ...ss/weld/tck/piranha/PiranhaExtension.java b/...ss/weld/tck/piranha/PiranhaExtension.java → ...ss/weld/tck/piranha/PiranhaExtension.java
diff --git a/...jboss/weld/tck/piranha/WeldBeansImpl.java → ...jboss/weld/tck/piranha/WeldBeansImpl.java b/...jboss/weld/tck/piranha/WeldBeansImpl.java → ...jboss/weld/tck/piranha/WeldBeansImpl.java
diff --git a/...oss/weld/tck/piranha/WeldContextImpl.java → ...oss/weld/tck/piranha/WeldContextImpl.java b/...oss/weld/tck/piranha/WeldContextImpl.java → ...oss/weld/tck/piranha/WeldContextImpl.java
diff --git a/...rg/jboss/weld/tck/piranha/WeldELImpl.java → ...rg/jboss/weld/tck/piranha/WeldELImpl.java b/...rg/jboss/weld/tck/piranha/WeldELImpl.java → ...rg/jboss/weld/tck/piranha/WeldELImpl.java
diff --git a/...est/resources/META-INF/cdi-tck.properties → ...est/resources/META-INF/cdi-tck.properties b/...est/resources/META-INF/cdi-tck.properties → ...est/resources/META-INF/cdi-tck.properties
diff --git a/...oss.arquillian.core.spi.LoadableExtension → ...oss.arquillian.core.spi.LoadableExtension b/...oss.arquillian.core.spi.LoadableExtension → ...oss.arquillian.core.spi.LoadableExtension
diff --git a/...er/core/src/test/resources/arquillian.xml → ...er/core/src/test/resources/arquillian.xml b/...er/core/src/test/resources/arquillian.xml → ...er/core/src/test/resources/arquillian.xml
diff --git a/.../coreprofile-tck/cdi/runner/model/pom.xml → external/tck/cdi/runner/model/pom.xml b/.../coreprofile-tck/cdi/runner/model/pom.xml → external/tck/cdi/runner/model/pom.xml
@@ -20,14 +20,14 @@
     <modelVersion>4.0.0</modelVersion>
 
     <parent>
-        <groupId>cloud.piranha.external.coreprofiletck.cditck.runner</groupId>
+        <groupId>cloud.piranha.external.tck.cdi.runner</groupId>
         <artifactId>project</artifactId>
         <version>24.11.0-SNAPSHOT</version>
     </parent>
 
-    <artifactId>lang-model</artifactId>
+    <artifactId>piranha-external-tck-cdi-runner-langmodel</artifactId>
 
-    <name>Piranha Core Profile - CDI TCK - Runner - Lang Model</name>
+    <name>Piranha - External - TCK - CDI - Runner - Lang Model</name>
     <description>Aggregates dependencies and runs the CDI Lang Model TCK on Piranha</description>
 
     <properties>

diff --git a/...cdi/lang/model/CDILangModelTCKRunner.java → ...cdi/lang/model/CDILangModelTCKRunner.java b/...cdi/lang/model/CDILangModelTCKRunner.java → ...cdi/lang/model/CDILangModelTCKRunner.java
diff --git a/...odelVerifierBuildCompatibleExtension.java → ...odelVerifierBuildCompatibleExtension.java b/...odelVerifierBuildCompatibleExtension.java → ...odelVerifierBuildCompatibleExtension.java
diff --git a/external/coreprofile-tck/cdi/runner/pom.xml → external/tck/cdi/runner/pom.xml b/external/coreprofile-tck/cdi/runner/pom.xml → external/tck/cdi/runner/pom.xml
@@ -4,16 +4,16 @@
     <modelVersion>4.0.0</modelVersion>
 
     <parent>
-        <groupId>cloud.piranha.external.coreprofiletck.cditck</groupId>
+        <groupId>cloud.piranha.external.tck.cdi</groupId>
         <artifactId>project</artifactId>
         <version>24.11.0-SNAPSHOT</version>
     </parent>
 
-    <groupId>cloud.piranha.external.coreprofiletck.cditck.runner</groupId>
+    <groupId>cloud.piranha.external.tck.cdi.runner</groupId>
     <artifactId>project</artifactId>
     <packaging>pom</packaging>
 
-    <name>Piranha Core Profile - CDI TCK - Runner - Project</name>
+    <name>Piranha - External - TCK - CDI - Runner - Project</name>
 
     <modules>
         <module>core</module>

diff --git a/...eprofile-tck/cdi/runner/signature/pom.xml → external/tck/cdi/runner/signature/pom.xml b/...eprofile-tck/cdi/runner/signature/pom.xml → external/tck/cdi/runner/signature/pom.xml
@@ -20,14 +20,14 @@
     <modelVersion>4.0.0</modelVersion>
 
     <parent>
-        <groupId>cloud.piranha.external.coreprofiletck.cditck.runner</groupId>
+        <groupId>cloud.piranha.external.tck.cdi.runner</groupId>
         <artifactId>project</artifactId>
         <version>24.11.0-SNAPSHOT</version>
     </parent>
 
-    <artifactId>signature</artifactId>
+    <artifactId>piranha-external-tck-cdi-runner-signature</artifactId>
 
-    <name>Piranha Core Profile - CDI TCK - Runner - Signature</name>
+    <name>Piranha - External - TCK - CDI - Runner - Signature</name>
     <description>Aggregates dependencies and runs the CDI Signature TCK on Piranha</description>
 
     <properties>
@@ -53,9 +53,9 @@
                                 <artifactItem>
                                     <groupId>jakarta.enterprise</groupId>
                                     <artifactId>cdi-tck-core-impl</artifactId>
-                                    <version>4.0.13</version>
+                                    <version>${cdi.tck.version}</version>
                                     <type>sig</type>
-                                    <classifier>sigtest-jdk11</classifier>
+                                    <classifier>sigtest-jdk17</classifier>
                                     <outputDirectory>${project.build.directory}/sigtest</outputDirectory>
                                 </artifactItem>
                             </artifactItems>
@@ -79,7 +79,7 @@
                                     <version>${piranha.version}</version>
                                     <type>jar</type>
                                     <overWrite>false</overWrite>
-                                    <outputDirectory>target/cdi-sigtest-classes</outputDirectory>
+                                    <outputDirectory>target/classes</outputDirectory>
                                 </artifactItem>
                             </artifactItems>
                         </configuration>
@@ -100,9 +100,9 @@
                     </execution>
                 </executions>
                 <configuration>
-                    <sigfile>target/sigtest/cdi-tck-core-impl-sigtest-jdk11.sig</sigfile>
+                    <sigfile>target/sigtest/cdi-tck-core-impl-sigtest-jdk17.sig</sigfile>
                     <packages>jakarta.decorator,jakarta.enterprise.**,jakarta.interceptor</packages>
-                    <classes>target/cdi-sigtest-classes</classes>
+                    <classes>target/classes</classes>
                     <report>target/cdi-sig-report.txt</report>
                 </configuration>
             </plugin>

diff --git a/external/tck/inject/runner/pom.xml b/external/tck/inject/runner/pom.xml
@@ -53,8 +53,7 @@
                             <target>
                                 <!-- Run the tests -->
                                 <exec dir="${tck.home}/example"
-                                      executable="mvn"
-                                      failonerror="true">
+                                      executable="mvn">
                                     <arg value="verify"/>
                                 </exec>
                             </target>

diff --git a/external/tck/jsonb/runner/pom.xml b/external/tck/jsonb/runner/pom.xml
@@ -29,6 +29,14 @@
             </dependency>
         </dependencies>
     </dependencyManagement>
+    <dependencies>
+        <dependency>
+            <groupId>cloud.piranha.external.tck.jsonb</groupId>
+            <artifactId>piranha-external-tck-jsonb-installer</artifactId>
+            <version>${project.version}</version>
+            <type>pom</type>
+        </dependency>
+    </dependencies>
 
     <build>
         <plugins>

diff --git a/external/tck/jsonp/runner/pom.xml b/external/tck/jsonp/runner/pom.xml
@@ -57,8 +57,7 @@
                                 <echo>Running JSON Processing TCK ${jsonp.tck.version} against Parsson ${parsson.version}</echo>
                                 <echo>----------------------------------------------------------</echo>
                                 <exec dir="${tck.home}/bin"
-                                      executable="mvn"
-                                      failonerror="true">
+                                      executable="mvn">
                                     <arg value="verify"/>
                                 </exec>
                                 <echo>----------------------------------------------------------</echo>

diff --git a/external/tck/pom.xml b/external/tck/pom.xml
@@ -17,6 +17,7 @@
 
     <modules>
         <module>annotations</module>
+        <module>cdi</module>
         <module>el</module>
         <module>inject</module>
         <module>jsonb</module>