URL and parser update for Smuggler's Notch #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that "Howie's Wanderer" lift uses a #x2019 right single quote and not an apostrophe like the other lifts, and displays incorrectly. Perhaps liftie should be specifying UTF8 as the character encoding in the response. |
|
Liftie only reports lift status - I updated the filter to do just that. BTW: before that change - all the names including Howie’s Wanderer display correctly. I am pretty sure Liftie respects page character encoding (utf8 in this case) when parsing HTML - but if you do think we should be doing this differently I am open to suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smuggler's Notch has changed its layout.