Added warning for unsupported Facebook FastText modes #3223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mpenkov, any feedback on this PR? it's my 1st contribution, lemme know if I have done it correctly? |
piskvorky
requested changes
Feb 19, 2022
| loss_names = {0 : "Negative_Sampling_Loss", 1 : "Hierarchical_Softmax_Loss", 2 : "Softmax_Loss", 3 : "OneVsAll_Loss"} | ||
| model_name = {1 : "Continuous_Bag_Of_Words", 2 : "Skip_Gram", 3 : "Supervised"} | ||
| if m.loss == 3 or m.loss == 4: | ||
| warnings.warn(f'Provided an un-supported Facebook FastText loss mode (i.e. un-supported loss: {loss_names[m.loss]}), \n it may lead to inconsistent gensim model likely to fail later. \n Currently Supported loss modes are {loss_names[0]}, {loss_names[1]}') |
There was a problem hiding this comment.
Shouldn't unsupported modes raise an exception? What's the use-case for loading an unsupported mode with a warning?
Suggested change
| warnings.warn(f'Provided an un-supported Facebook FastText loss mode (i.e. un-supported loss: {loss_names[m.loss]}), \n it may lead to inconsistent gensim model likely to fail later. \n Currently Supported loss modes are {loss_names[0]}, {loss_names[1]}') | |
| logger.warning(f"{model_file } contains an unsupported Facebook FastText loss mode '{loss_names[m.loss]}'. Loading it may lead to errors later on. Supported loss modes are '{loss_names[0]}', '{loss_names[1]}'.") |
| @@ -807,6 +809,14 @@ def _load_fasttext_format(model_file, encoding='utf-8', full_model=True): | |||
| with utils.open(model_file, 'rb') as fin: | |||
| m = gensim.models._fasttext_bin.load(fin, encoding=encoding, full_model=full_model) | |||
|
|
|||
| # Warnings regarding unsupported FB FT modes | |||
| loss_names = {0 : "Negative_Sampling_Loss", 1 : "Hierarchical_Softmax_Loss", 2 : "Softmax_Loss", 3 : "OneVsAll_Loss"} | |||
There was a problem hiding this comment.
Code style: no space before ::
Here and also in the line below please.
Suggested change
| loss_names = {0 : "Negative_Sampling_Loss", 1 : "Hierarchical_Softmax_Loss", 2 : "Softmax_Loss", 3 : "OneVsAll_Loss"} | |
| loss_names = {0: "Negative_Sampling_Loss", 1: "Hierarchical_Softmax_Loss", 2: "Softmax_Loss", 3: "OneVsAll_Loss"} |
| if m.loss == 3 or m.loss == 4: | ||
| warnings.warn(f'Provided an un-supported Facebook FastText loss mode (i.e. un-supported loss: {loss_names[m.loss]}), \n it may lead to inconsistent gensim model likely to fail later. \n Currently Supported loss modes are {loss_names[0]}, {loss_names[1]}') | ||
| if m.model == 3: | ||
| warnings.warn(f'Provided an un-supported Facebook FastText model mode (i.e. un-supported loss: {model_name[m.model]}), \n it may lead to inconsistent gensim model likely to fail later. \n Currently Supported model modes are {model_name[1]}, {model_name[2]}') |
There was a problem hiding this comment.
Dtto as above: either logger.warning, or an exception.
piskvorky
changed the title
piskvorky
changed the title
|
Closing in favour of #3222 because it's simpler. But thanks for contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3179: warn the user about the unsupported FastText mode they have chosen, and also inform them what the supported modes are.