Sync PyPi package description with Github README #3552
+15
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
unrelated to this PR, I started a conversation in the Google Groups Gensim forum (as recommended by your contribution guidelines when opening new issues) asking if working on adding type hints to gensim would be welcome work, but I haven't gotten any response. Just pinging that again here. |
IIRC setup.py (PyPI) used to required the RST format, whereas our README uses the Markdown format. That's why we kept two different descriptions, with just a stub (RST) for PyPI. If that's no longer the case and setup.py now supports markdown (which it apparently does), that's great. That simplifies things. Thanks for the PR! |
piskvorky
requested changes
Jul 18, 2024
piskvorky
reviewed
Jul 18, 2024
piskvorky
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3452
The reason your PyPi Project Page is out of sync is because of an out-dated hard-coded description in your setup.py file. To fix it:
setup.pynow uses the project README text forlong_description