feat: update account settings page #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
3em
reviewed
Jan 21, 2025
| @@ -74,18 +73,17 @@ const SettingsAccountGeneralPage: React.FC<SettingsAccountGeneralPageProps> = ({ | |||
| onUpdatePassword, | |||
| useTranslationStore | |||
| }) => { | |||
| // Profile form handling | |||
| const { t } = useTranslationStore() | |||
| const { userData } = useProfileSettingsStore() | |||
| const [profileSubmitted, setProfileSubmitted] = useState(false) | |||
| const [passwordSubmitted, setPasswordSubmitted] = useState(false) | |||
| const TRUNCATE_INITIALS_LEN = 2 | |||
There was a problem hiding this comment.
don't need it, can use getInitials without second prop
3em
reviewed
Jan 21, 2025
| const onPasswordSubmit: SubmitHandler<PasswordFields> = data => { | ||
| onUpdatePassword(data) | ||
| } | ||
|
|
||
| if (isLoadingUser) { | ||
| return ( | ||
| <SandboxLayout.Main> | ||
| <SandboxLayout.Content maxWidth="2xl"> | ||
| <SandboxLayout.Content> | ||
| <SkeletonList /> |
3em
reviewed
Jan 21, 2025
| </Avatar> | ||
| </ControlGroup> | ||
| <SandboxLayout.Content className="max-w-[476px] px-0"> | ||
| <Text size={5} weight={'medium'} as="h1"> |
There was a problem hiding this comment.
we should avoid using Text component - in future we will remove it at all, lets use h1 here
3em
reviewed
Jan 21, 2025
| <Avatar size="80" className="size-20 rounded-full bg-primary/[0.02] shadow-md"> | ||
| <AvatarImage src="/images/anon.jpg" /> | ||
| <AvatarFallback> | ||
| <Text size={5} weight="medium" color="tertiaryBackground"> |
There was a problem hiding this comment.
we should avoid using Text component - use span here
3em
reviewed
Jan 21, 2025
| <FormWrapper onSubmit={handleProfileSubmit(onProfileSubmit)}> | ||
| <Legend title={t('views:profileSettings.personalInfo', 'Personal information')} /> | ||
| <ControlGroup> | ||
| <Avatar size="80" className="size-20 rounded-full bg-primary/[0.02] shadow-md"> |
There was a problem hiding this comment.
we don't need all this classes, size use with separate prop size
3em
reviewed
Jan 21, 2025
| placeholder={t('views:profileSettings.enterNamePlaceholder', 'Enter your name')} | ||
| label={t('views:profileSettings.name', 'Name')} | ||
| /> | ||
| {profileErrors.name && ( |
There was a problem hiding this comment.
In the Input component, we have a special error prop for error messages, so this part of the code is not needed.
3em
reviewed
Jan 21, 2025
| disabled | ||
| label={t('views:profileSettings.username', 'Username')} | ||
| /> | ||
| <Message className="mt-1.5" theme={MessageTheme.DEFAULT}> |
There was a problem hiding this comment.
we have caption prop at Input component for input's description text
3em
reviewed
Jan 21, 2025
| @@ -51,6 +49,7 @@ export const SettingsProfileKeysPage = () => { | |||
| const [isAlertDeleteDialogOpen, setIsAlertDeleteDialogOpen] = useState(false) | |||
| const [alertParams, setAlertParams] = useState<AlertDeleteParams | null>(null) | |||
| const [searchParams] = useSearchParams() | |||
| const CONVERT_DAYS_TO_NANO_SECONDS = 24 * 60 * 60 * 1000 * 1000000 | |||
There was a problem hiding this comment.
Move the static variable out of the component.
3em
reviewed
Jan 21, 2025
| description={t( | ||
| 'views:profileSettings.addTokenDescription', | ||
| 'Personal access tokens allow you to authenticate with the API.' | ||
| <SandboxLayout.Content className="max-w-[812px] px-0"> |
3em
reviewed
Jan 21, 2025
| <Fieldset className="gap-y-5"> | ||
| <Legend | ||
| title={ | ||
| <span className="flex justify-between"> |
yasell
force-pushed
the
account-settings
branch
from
bfbc858 to
1f8f8fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the profile-settings page according to the design:
General Account Settings
Keys and Tokens
Create a token modal
Delete a token modal