Skip to content

refactor: tabs navigation #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor: tabs navigation #21

wants to merge 2 commits into from

Conversation

@ankormoreankor
Copy link
Collaborator

@ankormoreankor ankormoreankor commented Jan 30, 2025 •
edited
Loading

There was a bug in tabs: when switching between tabs with Tab button, you could go forward but get stuck when going backward. The issue is probably related to having links inside buttons in the Tabs component.

tabs.mp4
  • Moved tabs to the new TabNav component
  • Fixed the header height and the position of the tabs (55px -> 58px)

@vercel
Copy link

vercel bot commented Jan 30, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
canary ❌ Failed (Inspect) Mar 5, 2025 0:10am

@ankormoreankor ankormoreankor force-pushed the project-settings-review branch 3 times, most recently from 3d37b2e to 21037e8 Compare January 30, 2025 13:17
@ankormoreankor ankormoreankor force-pushed the tabs-navigation-refactoring branch from 81bb55e to b776a24 Compare January 30, 2025 13:24
andrewgolovanov
andrewgolovanov reviewed Jan 30, 2025
View reviewed changes
@ankormoreankor ankormoreankor force-pushed the tabs-navigation-refactoring branch from 8f80806 to 1b714a3 Compare January 31, 2025 09:31
@ankormoreankor ankormoreankor force-pushed the tabs-navigation-refactoring branch from 1b714a3 to 4572c28 Compare January 31, 2025 09:43
@iatopilskii iatopilskii force-pushed the project-settings-review branch from 21037e8 to e0f9328 Compare January 31, 2025 12:20
@ankormoreankor ankormoreankor changed the base branch from project-settings-review to main January 31, 2025 12:35
@ankormoreankor ankormoreankor changed the base branch from main to project-settings-review January 31, 2025 12:38
@ankormoreankor ankormoreankor changed the base branch from project-settings-review to main January 31, 2025 12:40
@ankormoreankor ankormoreankor force-pushed the tabs-navigation-refactoring branch from 4572c28 to 9f92d1c Compare January 31, 2025 13:02
@ankormoreankor ankormoreankor force-pushed the tabs-navigation-refactoring branch from 9f92d1c to a9be11c Compare January 31, 2025 13:08
@ankormoreankor ankormoreankor force-pushed the tabs-navigation-refactoring branch from a9be11c to faf1c0a Compare February 3, 2025 12:07
@ankormoreankor ankormoreankor force-pushed the tabs-navigation-refactoring branch from faf1c0a to 0eb786d Compare February 3, 2025 12:31
3em
3em reviewed Feb 4, 2025
View reviewed changes
@ankormoreankor ankormoreankor force-pushed the tabs-navigation-refactoring branch from 0eb786d to 0e2d371 Compare February 4, 2025 12:23
@ankormoreankor ankormoreankor requested a review from 3em February 4, 2025 13:05
@ankormoreankor ankormoreankor force-pushed the tabs-navigation-refactoring branch from 0e2d371 to 76ceae8 Compare February 5, 2025 07:15
@ankormoreankor ankormoreankor force-pushed the tabs-navigation-refactoring branch from a64ee34 to dbf8136 Compare February 26, 2025 09:59
@ankormoreankor ankormoreankor requested a review from 3em February 26, 2025 10:07
@3em 3em force-pushed the tabs-navigation-refactoring branch from dbf8136 to 0243776 Compare February 27, 2025 07:21
@3em 3em force-pushed the tabs-navigation-refactoring branch from 0243776 to 12d4e23 Compare February 27, 2025 07:21
@ankormoreankor ankormoreankor force-pushed the tabs-navigation-refactoring branch from 12d4e23 to c079212 Compare February 27, 2025 10:27
@ankormoreankor ankormoreankor force-pushed the tabs-navigation-refactoring branch from c079212 to 661994c Compare February 27, 2025 10:28
@3em 3em force-pushed the tabs-navigation-refactoring branch from 661994c to 18ceb1f Compare February 28, 2025 04:06
@ankormoreankor ankormoreankor force-pushed the tabs-navigation-refactoring branch from 18ceb1f to 1e8a600 Compare February 28, 2025 06:52
@ankormoreankor ankormoreankor force-pushed the tabs-navigation-refactoring branch from 1e8a600 to 7e37e3e Compare February 28, 2025 07:30
@ankormoreankor ankormoreankor force-pushed the tabs-navigation-refactoring branch from 7e37e3e to ea6197f Compare March 3, 2025 08:45
@ankormoreankor ankormoreankor force-pushed the tabs-navigation-refactoring branch from ea6197f to 9effc1c Compare March 3, 2025 08:48
@ankormoreankor ankormoreankor force-pushed the tabs-navigation-refactoring branch from 9effc1c to 51d72e0 Compare March 4, 2025 10:25
@ankormoreankor ankormoreankor force-pushed the tabs-navigation-refactoring branch from 51d72e0 to b37cbf9 Compare March 4, 2025 10:34
@ankormoreankor ankormoreankor force-pushed the tabs-navigation-refactoring branch from b37cbf9 to ac80a89 Compare March 5, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewgolovanov andrewgolovanov Awaiting requested review from andrewgolovanov

@3em 3em Awaiting requested review from 3em

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ankormoreankor @3em @andrewgolovanov